[Pkg-utopia-maintainers] Bug#906965: network-manager: tests will fail (FTBFS) with GLib 2.57 because it makes g_debug() a fatal error

[Simon McVittie]

Source: network-manager
Version: 1.12.0-4
Severity: important
Tags: patch fixed-upstream

While upgrading GLib to 2.57.x in a Debian derivative, I found that
NetworkManager will FTBFS with a test failure when that version is used,
for example:

[  236s] ERROR: src/tests/test-general-with-expect
[  236s] =========================================
[  236s]
[  236s] **
[  236s] test:ERROR:src/tests/test-general-with-expect.c:393:test_nm_utils_kill_child: assertion failed: (WIFEXITED (exit_status) && WEXITSTATUS(exit_status) == 0)
[  236s] ./tools/run-nm-test.sh: line 235: 10619 Aborted                 "${NMTST_DBUS_RUN_SESSION[@]}" "$TEST" "$@"
[  236s] # random seed: R02S91844261d2e3f659fd4c6852f1ff07c0
[  236s] 1..5
[  236s] # Start of general tests
[  236s] ok 1 /general/nm_utils_monotonic_timestamp_as_boottime
[  236s] PASS: src/tests/test-general-with-expect 1 /general/nm_utils_monotonic_timestamp_as_boottime
[  236s] Bail out! GLib-FATAL-DEBUG: posix_spawn avoided (automatic reaping requested) (fd close requested)
[  236s] ERROR: src/tests/test-general-with-expect - Bail out! GLib-FATAL-DEBUG: posix_spawn avoided (automatic reaping requested) (fd close requested)
[  236s] Bail out! test:ERROR:src/tests/test-general-with-expect.c:393:test_nm_utils_kill_child: assertion failed: (WIFEXITED (exit_status) && WEXITSTATUS(exit_status) == 0)

GLib 2.57 is available in Debian experimental.

I know the NM version we're using is a bit out of date, but I checked
upstream and Debian git and it doesn't look as though this was fixed
subsequently in the upstream 1.12.x branch or in Debian. It appears to
have been fixed in upstream 1.13.3 by this commit:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/3e8eef538987c909e87b871a6b8c74aee08661a3

This will become RC for Debian (unless I was wrong about its
reproducibility) when glib2.0 2.57.x/2.58.x are ready to be uploaded
to unstable.

Thanks,
    smcv