[Pkg-utopia-maintainers] Bug#895261: RFS: dbus-broker/13-2 [ITP] -- Linux D-Bus Message Broker

[Michael Biebl]

Am 17.05.2018 um 22:15 schrieb Daniele Nicolodi:
> Hello all,
> 
> I'm still looking for a sponsor for this package. Would anyone have a
> bit of spare time to look at it and let me know how it can be made fit
> for upload?
> 
> Is there any specific reason why this package is harder to review than
> others? It is a bit discouraging not having received any feedback after
> five package updates and more than a month from the first RFS.

I had a short look at the package
Two issues I noticed:
a/ a hard dep on systemd-sysv. Is dbus-broker strictly systemd-only? The
launcher part probably is, but the messaging part should be init system
agnostic? Would it be possible that a launcher for sysvinit could
replace the systemd specific launcher? Should this be reflected in the
packaging by splitting of the launcher part?
If this is not possible and not intended, then it might possibly be a
good idea to document somewhere why dbus-broker is systemd-only.

b/ /etc/systemd/user/dbus.service ->
/usr/lib/systemd/user/dbus-broker.service symlink

I know that systemd user services currently are not yet supported by
init-system-helpers. Shipping a symlink in /etc in the package is
semi-optimal though. Afair, symlinks are not treated like real conffiles
and are re-created on package upgrades. So if an admin disables the user
part of dbus-broker, it will be re-enabled, so you might just as well
ship the symlink in /usr/lib/systemd/user.
The alternative is to ship the user part not-enabled by default and
document that this needs to be enabled manually.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-utopia-maintainers/attachments/20180529/0fe14dd3/attachment.sig>