[Pkg-utopia-maintainers] Bug#913729: wrong modinfo path if compiled on merged-usr system and executed on unmerged system

[Michael Biebl]

Package: firewalld
Version: 0.6.3-2
Severity: serious

Trying to start firewalld, I get:
Nov 14 13:05:04 pluto firewalld[1126]: WARNING: modinfo command is missing, not able to detect conntrack helpers.
Nov 14 13:05:04 pluto firewalld[1126]: ERROR: Failed to load nf_conntrack module:
Nov 14 13:05:04 pluto firewalld[1126]: ERROR: Raising SystemExit in run_server

The culprit is:

configure.ac:AC_PATH_PROG([MODINFO], [modinfo], [/sbin/modinfo])
configure.ac:AC_PATH_PROG([MODPROBE], [modprobe], [/sbin/modprobe])
configure.ac:AC_PATH_PROG([RMMOD], [rmmod], [/sbin/rmmod])
configure.ac:AC_PATH_PROG([SYSCTL], [sysctl], [/sbin/sysctl])
config/Makefile.am:	-e 's|@MODPROBE[@]|$(MODPROBE)|g' \
config/Makefile.am:	-e 's|@SYSCTL[@]|$(SYSCTL)|g'
config/firewalld-sysctls.conf.in:install nf_conntrack @MODPROBE@ --ignore-install nf_conntrack $CMDLINE_OPTS && @SYSCTL@ --quiet --pattern 'net[.]netfilter[.]nf_conntrack.*' --system
src/firewall/config/__init__.py.in:SYSCTL_CONFIG = '/etc/sysctl.conf'
src/firewall/config/__init__.py.in:    "modinfo":      "@MODINFO@",
src/firewall/config/__init__.py.in:    "modprobe":     "@MODPROBE@",
src/firewall/config/__init__.py.in:    "rmmod":        "@RMMOD@",


I.e. AC_PATH_PROG return the wrong path when built in a merged-usr
system.
I suspect that this particular problem is very widespread, so i was
wondering if we couldn't just address this once in the AC_PATH_PROG [1]
macro, by preferring /bin/ over /usr/bin. Atm, it searches PATH, which
is usually set to
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games

Wdyt?

Michael

[1] /usr/share/autoconf/autoconf/programs.m4

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages firewalld depends on:
ii  dbus                 1.12.10-1
ii  gir1.2-glib-2.0      1.58.0-1
ii  init-system-helpers  1.55
ii  iptables             1.8.1-2
ii  policykit-1          0.105-21
ii  python3              3.6.7-1
ii  python3-dbus         1.2.8-2+b1
ii  python3-gi           3.30.1-2
ii  python3-slip-dbus    0.6.5-2

Versions of packages firewalld recommends:
ii  ebtables  2.0.10.4-5
ii  ipset     6.38-1

firewalld suggests no packages.

-- Configuration Files:
/etc/firewalld/firewalld.conf [Errno 13] Keine Berechtigung: '/etc/firewalld/firewalld.conf'
/etc/firewalld/lockdown-whitelist.xml [Errno 13] Keine Berechtigung: '/etc/firewalld/lockdown-whitelist.xml'

-- no debconf information