[Pkg-utopia-maintainers] Bug#935798: firewalld: patches from Ubuntu (test fixes and ebtables Recommendation)

[Gianfranco Costamagna]

Source: firewalld
Version: 0.7.1-1
Severity: important
tags: patch

Hello, I would like to request you some little fix on your package if possible.

1) Recomend ebtables installation

diff -Nru firewalld-0.7.1/debian/control firewalld-0.7.1/debian/control
--- firewalld-0.7.1/debian/control      2019-07-23 00:18:50.000000000 +0200
+++ firewalld-0.7.1/debian/control      2019-07-29 23:56:18.000000000 +0200
@@ -31,7 +31,8 @@
          python3-slip-dbus,
          ${misc:Depends},
          ${python3:Depends}
-Recommends: ipset
+Recommends: ebtables (>= 2.0.10.4-3.1~),
+            ipset
 Breaks: cockpit-ws (<< 176)
 Replaces: cockpit-ws (<< 176)
 Description: dynamically managed firewall with support for network zones


As you can see, it is even requested in the testsuite, I don't see why not recommend it
(people might find useful to know/have it installed, because it obviously work with ebtables too)


2) add intltool to debian/tests/control.
In some environment, automake --refresh is run before tests to recreate the needed files, and fails because of missing intltool


diff -Nru firewalld-0.7.1/debian/tests/control firewalld-0.7.1/debian/tests/control
--- firewalld-0.7.1/debian/tests/control        2019-07-23 00:18:50.000000000 +0200
+++ firewalld-0.7.1/debian/tests/control        2019-07-29 23:56:18.000000000 +0200
@@ -4,6 +4,7 @@
          python3-dbus,
          python3-gi,
          automake,
+         intltool,
          nftables,
          ipset,
          iptables,


please have a look!