[Pkg-utopia-maintainers] Bug#918439: cockpit: FTBFS (failing tests)

[Andreas Henriksson]

Hello,

On Sun, Jan 06, 2019 at 12:55:49AM +0000, Santiago Vila wrote:
> Package: src:cockpit
> Version: 184-1
> Severity: serious
> Tags: ftbfs
[...]
> ============================================================================
> Testsuite summary for Cockpit 184
> ============================================================================
> # TOTAL: 882
> # PASS:  806
> # SKIP:  45
> # XFAIL: 0
> # FAIL:  31

Lots of failing tests there....

> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See ./test-suite.log
> Please report to devel at lists.cockpit-project.org
> ============================================================================
[...]
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/cockpit.html
[...]

I just looked at the first one and it fails here:

$ head -n 57 src/common/test-webserver.c  | tail -n 2
  inet = cockpit_test_find_non_loopback_address ();
  g_assert (inet != NULL);

I'm thus going to assume that the build environments that runs into
these problems uses network namespaces or similar and doesn't expose
anything but loopback to the build chroot.

I looked a bit closer at cockpit_test_find_non_loopback_address
in src/common/cockpittest.c and it seems it needs the following
conditions met:
- interface is up
- ipv4 or ipv6 address configured
- g_inet_address_get_is_loopback () returning false for a found address

I presume the rest of the "webserver" tests fail for followup reasons
related to that, but there are also other tests that fails that
I haven't really diven deeper into to find why they fail.

It might be a good idea to first just test if all problems vanishes
if builting in a less network restricted environment, maybe that
confirms the suspision without having to dive deep in every problem
instantly.

HTH

The long-term solution should probably be that the test-suite
automatically checks pre-conditions it has and skips the tests
that can not be run under the current build environment automatically.

Regards,
Andreas Henriksson