[Pkg-utopia-maintainers] Bug#910124: Bug#910124: network-manager-gnome: option to import/export WiFi config as a QR code

[Salvatore Bonaccorso]

Hi Michael,

On Mon, Jun 03, 2019 at 08:52:28AM +0200, Michael Biebl wrote:
> Am 01.06.19 um 21:37 schrieb Salvatore Bonaccorso:
> 
> > On Fri, May 31, 2019 at 02:57:13PM +0200, Salvatore Bonaccorso wrote:
> 
> >> Is that the same as src:qr-code-generator as present in unstable, cf.
> >> https://tracker.debian.org/pkg/qr-code-generator . 
> >>
> >> Is the network-manager-applet embedded copy unmodified? If so it would
> >> be preferable if network-manager-applet could switch to the system
> >> one.
> > 
> > So src/libnma/qrcodegen.c in src:network-manager-applet/1.8.22 is the
> > same c/qrcodegen.c as in src:qr-code-generator/1.4.0 apart whitespace
> > changes.
> 
> I've filed
> https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/187

Thanks!

While investigating I noticed, that the source comments gives a reason about it
in nma-bar-code.c:

> /*
>  * The aim of this class is to provide a GObject-y QR code generator based
>  * on qrcodegen library [1].  We purposefully include it directly instead
>  * of compiling it separately, while providing a much less flexible (and
>  * more straightforward) API. This way we the compiler does a good job at
>  * slimming things down (chopping off half of the library) while allowing
>  * us to leave the original source unmodified for easier maintenance.
>  *
>  * [1] https://github.com/nayuki/QR-Code-generator
>  */
>
> #pragma GCC visibility push(hidden)
> NM_PRAGMA_WARNING_DISABLE("-Wdeclaration-after-statement")
> #define NDEBUG
> #include "qrcodegen.c"
> NM_PRAGMA_WARNING_REENABLE
> #pragma GCC visibility pop

Though still this means, that if an issue appears in qr-code-generator
depending on the case, this *might* affect network-manager-applet as well. Not
sure if upstream can be convinced to change and not include a copy and use it
as above. Might not be possible or desirable in this case still. 

Let's see what upstream will say on it.

Regards,
Salvatore