[Pkg-utopia-maintainers] Bug#960752: FTBFS on arch-all, test-suite failure - conova buildd has broken "localhost"

[Martin Pitt]

Control: retitle -1 FTBFS on IPv6-only hosts
Control: found -1 188-1
Control: forwarded -1 https://github.com/cockpit-project/cockpit/pull/14098
Control: tag -1 patch upstream

Hello Aurelien,

Aurelien Jarno [2020-05-16 19:27 +0200]:
> This is an IPv6 host only,

Ah! This explains the issue indeed. I'm able to reproduce this now.

To unbreak unstable users ASAP, I uploaded a binary-all build for now.

Aurelien Jarno [2020-05-17 17:04 +0200]:
> As g_network_address_parse() supports escaping addresses with [] even
> for IPv4 addresses, I guess the following *untested* patch should fix
> the issue.
> 
> --- a/src/common/test-webserver.c
> +++ b/src/common/test-webserver.c
> @@ -93,7 +93,7 @@
>    /* HACK: this should be "localhost", but this fails on COPR; https://github.com/cockpit-project/cockpit/issues/12423 */
>    tc->localport = g_strdup_printf ("127.0.0.1:%d", port);
>    if (str)
> -    tc->hostport = g_strdup_printf ("%s:%d", str, port);
> +    tc->hostport = g_strdup_printf ("[%s]:%d", str, port);
>    if (inet)
>      g_object_unref (inet);
>    g_free (str);

Spot on, thank you! 👏 I tested this and sent an upstream PR to fix this.

Martin