[Pkg-utopia-maintainers] Bug#984127: flatpak: ftbfs with GCC-11

[Matthias Klose]

Package: src:flatpak
Version: 1.10.1-3
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/flatpak_1.10.1-3_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
echo "Exec=env G_TEST_SRCDIR=/usr/libexec/installed-tests/Flatpak G_TEST_BUILDDIR=/usr/libexec/installed-tests/Flatpak $wrapper /usr/libexec/installed-tests/Flatpak/test-extensions.sh --tap" >> tests/test-extensions.sh.test.tmp; \
echo 'Output=TAP' >> tests/test-extensions.sh.test.tmp; \
mv tests/test-extensions.sh.test.tmp tests/test-extensions.sh.test)
(echo '[Test]' > tests/test-oci.sh.test.tmp; \
echo 'Type=session' >> tests/test-oci.sh.test.tmp; \
if [[ test-oci.sh == *.wrap ]]; then \
    wrapper=/usr/libexec/installed-tests/Flatpak/test-wrapper.sh; \
fi; \
echo "Exec=env G_TEST_SRCDIR=/usr/libexec/installed-tests/Flatpak G_TEST_BUILDDIR=/usr/libexec/installed-tests/Flatpak $wrapper /usr/libexec/installed-tests/Flatpak/test-oci.sh --tap" >> tests/test-oci.sh.test.tmp; \
echo 'Output=TAP' >> tests/test-oci.sh.test.tmp; \
mv tests/test-oci.sh.test.tmp tests/test-oci.sh.test)
(echo '[Test]' > tests/test-override.sh.test.tmp; \
echo 'Type=session' >> tests/test-override.sh.test.tmp; \
if [[ test-override.sh == *.wrap ]]; then \
    wrapper=/usr/libexec/installed-tests/Flatpak/test-wrapper.sh; \
fi; \
echo "Exec=env G_TEST_SRCDIR=/usr/libexec/installed-tests/Flatpak G_TEST_BUILDDIR=/usr/libexec/installed-tests/Flatpak $wrapper /usr/libexec/installed-tests/Flatpak/test-override.sh --tap" >> tests/test-override.sh.test.tmp; \
echo 'Output=TAP' >> tests/test-override.sh.test.tmp; \
mv tests/test-override.sh.test.tmp tests/test-override.sh.test)
(echo '[Test]' > tests/test-auth.sh.test.tmp; \
echo 'Type=session' >> tests/test-auth.sh.test.tmp; \
if [[ test-auth.sh == *.wrap ]]; then \
    wrapper=/usr/libexec/installed-tests/Flatpak/test-wrapper.sh; \
fi; \
echo "Exec=env G_TEST_SRCDIR=/usr/libexec/installed-tests/Flatpak G_TEST_BUILDDIR=/usr/libexec/installed-tests/Flatpak $wrapper /usr/libexec/installed-tests/Flatpak/test-auth.sh --tap" >> tests/test-auth.sh.test.tmp; \
echo 'Output=TAP' >> tests/test-auth.sh.test.tmp; \
mv tests/test-auth.sh.test.tmp tests/test-auth.sh.test)
(echo '[Test]' > tests/test-unused.sh.test.tmp; \
echo 'Type=session' >> tests/test-unused.sh.test.tmp; \
if [[ test-unused.sh == *.wrap ]]; then \
    wrapper=/usr/libexec/installed-tests/Flatpak/test-wrapper.sh; \
fi; \
echo "Exec=env G_TEST_SRCDIR=/usr/libexec/installed-tests/Flatpak G_TEST_BUILDDIR=/usr/libexec/installed-tests/Flatpak $wrapper /usr/libexec/installed-tests/Flatpak/test-unused.sh --tap" >> tests/test-unused.sh.test.tmp; \
echo 'Output=TAP' >> tests/test-unused.sh.test.tmp; \
mv tests/test-unused.sh.test.tmp tests/test-unused.sh.test)
/usr/bin/msgfmt --xml -d ./po --template system-helper/org.freedesktop.Flatpak.policy.in -o system-helper/org.freedesktop.Flatpak.policy || cp system-helper/org.freedesktop.Flatpak.policy.in system-helper/org.freedesktop.Flatpak.policy
/bin/sed -e "s|\@privileged_group\@|sudo|" system-helper/org.freedesktop.Flatpak.rules.in > system-helper/org.freedesktop.Flatpak.rules
/bin/sed -e "s|\@libexecdir\@|/usr/libexec|" \
	-e "s|\@localstatedir\@|/var|" \
	-e "s|\@media_dir\@|/media|" \
	-e "s|\@extraargs\@||" system-helper/flatpak-system-helper.service.in > system-helper/flatpak-system-helper.service
/bin/sed -e "s|\@libexecdir\@|/usr/libexec|" \
	-e "s|\@localstatedir\@|/var|" \
	-e "s|\@media_dir\@|/media|" \
	-e "s|\@extraargs\@||" session-helper/flatpak-session-helper.service.in > session-helper/flatpak-session-helper.service
/bin/sed -e "s|\@libexecdir\@|/usr/libexec|" \
	-e "s|\@localstatedir\@|/var|" \
	-e "s|\@media_dir\@|/media|" \
	-e "s|\@extraargs\@||" portal/flatpak-portal.service.in > portal/flatpak-portal.service
/bin/sed -e "s|\@libexecdir\@|/usr/libexec|" \
	-e "s|\@localstatedir\@|/var|" \
	-e "s|\@media_dir\@|/media|" \
	-e "s|\@extraargs\@||" oci-authenticator/flatpak-oci-authenticator.service.in > oci-authenticator/flatpak-oci-authenticator.service
/bin/sed \
  -e "s|\@SYSTEM_HELPER_USER\@|_flatpak|" \
  system-helper/flatpak.conf.in > system-helper/flatpak.conf
gcc -DHAVE_CONFIG_H -I.  -DFLATPAK_BINDIR=\"/usr/bin\" -DFLATPAK_SYSTEMDIR=\"/var/lib/flatpak\" -DFLATPAK_CONFIGDIR=\"/etc/flatpak\" -DFLATPAK_BASEDIR=\"/usr/share/flatpak\" -DFLATPAK_TRIGGERDIR=\"/usr/share/flatpak/triggers\" -DSYSTEM_FONTS_DIR=\"/usr/share/fonts\" -DSYSTEM_HELPER_USER=\"_flatpak\" -DSYSTEM_FONT_CACHE_DIRS=\"/var/cache/fontconfig:/usr/lib/fontconfig/cache\" -DG_LOG_DOMAIN=\"flatpak\" -I./libglnx -I./common -I./common -include "config.h"  -DHELPER=\"bwrap\"  -DDBUSPROXY=\"xdg-dbus-proxy\"  -Wdate-time -D_FORTIFY_SOURCE=2 -pipe -Wall -Werror=shadow -Werror=empty-body -Werror=strict-prototypes -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=format=2 -Werror=format-security -Werror=format-nonliteral -Werror=pointer-arith -Werror=init-self -Werror=missing-declarations -Werror=return-type -Werror=overflow -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=misleading-indentation -Werror=missing-include-dirs  -pthread -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/ostree-1 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/json-glib-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libappstream-glib -I/usr/include/uuid -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -pthread -I/usr/include/polkit-1 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DFLATPAK_COMPILATION -I./app -I./app -DLIBEXECDIR=\"/usr/libexec\" -DLOCALEDIR=\"/usr/share/locale\"  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o app/flatpak-flatpak-main.o `test -f 'app/flatpak-main.c' || echo './'`app/flatpak-main.c
cc1: some warnings being treated as errors
make[3]: *** [Makefile:4946: portal/flatpak_portal-flatpak-permission-dbus.o] Error 1
make[3]: *** Waiting for unfinished jobs....
cc1: some warnings being treated as errors
make[3]: *** [Makefile:4960: portal/flatpak_portal-flatpak-portal-dbus.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:5937: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:2532: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:11: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2