[Pkg-utopia-maintainers] Request for review: pipewire-module-xrdp

[Dylan Aïssi]

Hello Arnaud,

Le jeu. 7 mars 2024 à 04:44, Arnaud Rebillout <arnaudr at debian.org> a écrit :
>
> - https://salsa.debian.org/arnaudr/pipewire-module-xrdp
> - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037111

You are right, it's the first pipewire module outside the main package.
So, let's try to clear the way:

What about using "libpipewire-0.3-module-xrdp" for binary package
name? It makes it consistent with other modules packages we have
(libpipewire-0.3-modules and libpipewire-0.3-modules-x11 ) and
this shows that it's a libpipewire-0.3 plugin. Moreover, this name
scheme is close to the one use for gstreamer plugin
(i.e. gstreamer1.0-blabla).

In the build log, dpkg-shlibdeps warns about unresolvable references
to symbols from libpipewire-0.3, maybe only a false positives since
it is a plugin but worth investigating.

I would add a dependency on "pipewire" to be sure its services
are installed. I don't know if this module is useful without a session
manager otherwise you would also need to add wireplumber as
dependency.

Some comments about the upstream load_pw_modules.sh
it refers to the Debian wiki which is nice :-) but not sure this is the
best reference for pipewire. For example, it uses configuration
that doesn't exist, I was asked by upstream to update our wiki about
that :-)
https://wiki.debian.org/PipeWire?action=diff&rev2=49&rev1=48
It is an upstream bug, but I guess they need to refresh their
load_pw_modules.sh.

These are just a few suggestions after a quick review.

> I CCed Dylan, as I'm not sure that the address
> pkg-utopia-maintainers at lists.alioth.debian.org reaches anyone out there.
> Please tell me if there's another point of contact for the Utopia team.

Some discussions happen here, so it's fine.

> Additionally, I'd be happy to move this repo under the utopia-team Salsa
> group for maintenance going forward.

I don't have enough permissions to add you to the group, I guess we will
need help from someone else.

> Arnaud
>

Best regards,
Dylan