[Pkg-utopia-maintainers] Request for review: pipewire-module-xrdp

[Arnaud Rebillout]

Hello Dylan,

I have worked with upstream on some details, and they release a v0.2 
version. I update the packaging on Salsa. See below for more details.

On 12/03/2024 4:16 am, Dylan Aïssi wrote:
> Hello Arnaud,
>
> Le jeu. 7 mars 2024 à 04:44, Arnaud Rebillout <arnaudr at debian.org> a écrit :
>> - https://salsa.debian.org/arnaudr/pipewire-module-xrdp
>> - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037111
> You are right, it's the first pipewire module outside the main package.
> So, let's try to clear the way:
>
> What about using "libpipewire-0.3-module-xrdp" for binary package
> name? It makes it consistent with other modules packages we have
> (libpipewire-0.3-modules and libpipewire-0.3-modules-x11 ) and
> this shows that it's a libpipewire-0.3 plugin. Moreover, this name
> scheme is close to the one use for gstreamer plugin
> (i.e. gstreamer1.0-blabla).

Done, now the package is split in two:

- libpipewire-0.3-modules-xrdp only provides the .so
- pipewire-module-xrdp provides the integration scripts that load the 
module when a xrdp session is started. It Depends on 
libpipewire-0.3-modules-xrdp.

Please refer to the commit message for more details.


> In the build log, dpkg-shlibdeps warns about unresolvable references
> to symbols from libpipewire-0.3, maybe only a false positives since
> it is a plugin but worth investigating.

Fixed upstream, cf. 
https://github.com/neutrinolabs/pipewire-module-xrdp/commit/c4d9bb3b8fb79c0b5d8af840ea479a5c1dcdff25


> I would add a dependency on "pipewire" to be sure its services
> are installed. I don't know if this module is useful without a session
> manager otherwise you would also need to add wireplumber as
> dependency.

I actually went the other way, and even removed the dependency on 
pipewire-bin.

Here's the main use-case: a user runs Linux in a VM, they have a desktop 
environment installed in this VM, and they plan to connect via xrdp. 
Thus they install the package xrdp in the VM.

What I plan to do is to add pipewire-module-xrdp as a Recommends of the 
xrdp package, so that users get audio support out-of-the-box with xrdp, 
without the need to install or configure anything else. The thing is: 
installing xrdp shouldn't decide what's the audio server in the VM, and 
shouldn't force installation of pipewire. Maybe pipewire is already 
installed: they get audio working. Maybe pipewire is not installed, and 
in that case, pipewire-module-xrdp is a no-op, it's installed (via 
dependency xrdp -> pipewire-module-xrdp), but it's not active.

Hope that makes sense to you, and happy to clarify if needed!


> Some comments about the upstream load_pw_modules.sh
> it refers to the Debian wiki which is nice :-) but not sure this is the
> best reference for pipewire. For example, it uses configuration
> that doesn't exist, I was asked by upstream to update our wiki about
> that :-)
> https://wiki.debian.org/PipeWire?action=diff&rev2=49&rev1=48
> It is an upstream bug, but I guess they need to refresh their
> load_pw_modules.sh.
>
> These are just a few suggestions after a quick review.

I agree with your comment, but I couldn't find any doc upstream that is 
similar to what's in the Debian wiki, so I can't really update the link.

As for the script load_pw_modules.sh, I ran some tests, and found some 
issues, so I opened a bug upstream: 
https://github.com/neutrinolabs/pipewire-module-xrdp/issues/6.

This being said, I don't have the bandwidth, nor the right setup, to 
really investigate this issue. The right setup is: a Windows host, and a 
Linux guest running in Hyper-V.

If we're lucky we'll get feedback from users in the future, and maybe 
we'll be able to improve this script.


>
>> Additionally, I'd be happy to move this repo under the utopia-team Salsa
>> group for maintenance going forward.
> I don't have enough permissions to add you to the group, I guess we will
> need help from someone else.

Do you know who to ping by any chance?


Last words: I noticed some new warning messages during the build (sigh), 
I don't really know what to do about it:

    dh_gencontrol
   dpkg-gencontrol: warning: Depends field of package 
libpipewire-0.3-modules-xrdp: substitution variable ${misc:Depends} 
used, but is not defined
   dpkg-gencontrol: warning: Depends field of package 
libpipewire-0.3-modules-xrdp: substitution variable ${shlibs:Depends} 
used, but is not defined

Best,

Arnaud