[Pkg-utopia-maintainers] Request for review: pipewire-module-xrdp

[Arnaud Rebillout]

Hey Dylan,

thanks for your suggestions. I will add pipewire-bin to Suggests, and I 
just pinged the #debian-gnome IRC channel.

I'll shot one last email after the package is uploaded and sleeping in 
the NEW queue.

Best,

Arnaud

On 26/03/2024 11:09 pm, Dylan Aïssi wrote:
> Hello Arnaud,
>
> Le mar. 26 mars 2024 à 09:45, Arnaud Rebillout <arnaudr at debian.org> a écrit :
>> I have worked with upstream on some details, and they release a v0.2
>> version. I update the packaging on Salsa. See below for more details.
> Thanks!
>
>> Done, now the package is split in two:
>>
>> - libpipewire-0.3-modules-xrdp only provides the .so
>> - pipewire-module-xrdp provides the integration scripts that load the
>> module when a xrdp session is started. It Depends on
>> libpipewire-0.3-modules-xrdp.
>>
>> Please refer to the commit message for more details.
> It looks great!
>
>>> In the build log, dpkg-shlibdeps warns about unresolvable references
>>> to symbols from libpipewire-0.3, maybe only a false positives since
>>> it is a plugin but worth investigating.
>> Fixed upstream, cf.
>> https://github.com/neutrinolabs/pipewire-module-xrdp/commit/c4d9bb3b8fb79c0b5d8af840ea479a5c1dcdff25
> \o/
>
>>> I would add a dependency on "pipewire" to be sure its services
>>> are installed. I don't know if this module is useful without a session
>>> manager otherwise you would also need to add wireplumber as
>>> dependency.
>> I actually went the other way, and even removed the dependency on
>> pipewire-bin.
> In this case, I would keep pipewire-bin but in the Suggests field.
> I received several bug reports for pipewire because users were not
> able to find which (plugin) packages they had to install, so having
> them in the Suggests field is enough for the majority of users to find
> relevant packages ;-).
>
>>> Some comments about the upstream load_pw_modules.sh
>>> it refers to the Debian wiki which is nice :-) but not sure this is the
>>> best reference for pipewire. For example, it uses configuration
>>> that doesn't exist, I was asked by upstream to update our wiki about
>>> that :-)
>>> https://wiki.debian.org/PipeWire?action=diff&rev2=49&rev1=48
>>> It is an upstream bug, but I guess they need to refresh their
>>> load_pw_modules.sh.
>>>
>>> These are just a few suggestions after a quick review.
>> I agree with your comment, but I couldn't find any doc upstream that is
>> similar to what's in the Debian wiki, so I can't really update the link.
>>
>> As for the script load_pw_modules.sh, I ran some tests, and found some
>> issues, so I opened a bug upstream:
>> https://github.com/neutrinolabs/pipewire-module-xrdp/issues/6.
>>
>> This being said, I don't have the bandwidth, nor the right setup, to
>> really investigate this issue. The right setup is: a Windows host, and a
>> Linux guest running in Hyper-V.
>>
>> If we're lucky we'll get feedback from users in the future, and maybe
>> we'll be able to improve this script.
> Yep, let's keep some fun for later :-)
>
>>>> Additionally, I'd be happy to move this repo under the utopia-team Salsa
>>>> group for maintenance going forward.
>>> I don't have enough permissions to add you to the group, I guess we will
>>> need help from someone else.
>> Do you know who to ping by any chance?
> Usually for discussion around pipewire or requests for assistance in the
> utopia team I ask #debian-gnome, smcv or biebl may help you.
>
>> Last words: I noticed some new warning messages during the build (sigh),
>> I don't really know what to do about it:
>>
>>      dh_gencontrol
>>     dpkg-gencontrol: warning: Depends field of package
>> libpipewire-0.3-modules-xrdp: substitution variable ${misc:Depends}
>> used, but is not defined
>>     dpkg-gencontrol: warning: Depends field of package
>> libpipewire-0.3-modules-xrdp: substitution variable ${shlibs:Depends}
>> used, but is not defined
> These are usual warnings, these substitution variables are defined in
> debian/control but substituted by nothing, I just let dpkg-gencontrol
> complain, but if it bothers you, you can remove them from d/control.
>
> Best,
> Dylan