[Pkg-utopia-maintainers] Bug#1082121: libostree-1-1: `flatpak update` fails: src/libostree/ostree-fetcher-curl.c:534:sock_cb: code should not be reached

[Simon McVittie]

Package: libostree-1-1
Version: 2024.7-2
Severity: important
Tags: upstream
Forwarded: https://github.com/ostreedev/ostree/issues/3299
Control: affects -1 + src:flatpak
X-Debbugs-Cc: curl at packages.debian.org

After upgrading curl to 8.10.0, `flatpak update` fails with:

> OSTree:ERROR:src/libostree/ostree-fetcher-curl.c:534:sock_cb: code should not be reached
> Bail out! OSTree:ERROR:src/libostree/ostree-fetcher-curl.c:534:sock_cb: code should not be reached
> [1]    21258 IOT instruction (core dumped)  flatpak update

Looking at the line with the assertion failure, it seems that we're
getting CURL_POLL_REMOVE from the CURLMOPT_SOCKETFUNCTION for a socket
that we either didn't add to the table of known sockets yet, or already
removed from the table of known sockets.

According to users of Alpine Linux, the trigger for this was when this
libcurl commit was applied (originally as a patch, now in the upstream
release):
https://github.com/curl/curl/commit/48f61e781a01e6a8dbc4a347e280644b1c68ab6a
but I haven't independently verified this.

    smcv