[Pkg-utopia-maintainers] Bug#1106215: unblock: xdg-desktop-portal/1.20.3+ds-1

[Simon McVittie]

Package: release.debian.org
Severity: normal
X-Debbugs-Cc: xdg-desktop-portal at packages.debian.org, debian-desktop at lists.debian.org, snapd at packages.debian.org
Control: affects -1 + src:xdg-desktop-portal
User: release.debian.org at packages.debian.org
Usertags: unblock

[ Reason ]
Fix broken functionality in 1.20.0 (#1105889) and regressions in 1.20.1
(#1106091)

[ Impact ]
With 1.20.0, Flatpak apps cannot successfully use the "dynamic launcher"
interface to ask permission to create an app shortcut on the host
(#1105889). I requested and was given an unblock for 1.20.1 in #1105893,
but unfortunately that version contained regressions when used with
a less-common category of Flatpak apps.

Following upstream's stable branch will make it easier to get future
bugfixes into trixie, potentially including security fixes.

[ Tests ]
I was able to reproduce #1106091 with a Flatpak app
(org.gnome.NautilusPreviewer, the Flatpak equivalent of gnome-sushi.deb).
I confirmed that the changes in 1.20.2 fix the x-d-p crash, but leave this
app with reduced functionality (the Open button results in an error). I also
confirmed that the changes in 1.20.3 restore previous functionality for
this app, with the Open button prompting the user to open the previewed
image in an appropriate host app as expected.
(https://github.com/flatpak/xdg-desktop-portal/issues/1718#issuecomment-2891394948,
https://github.com/flatpak/xdg-desktop-portal/issues/1718#issuecomment-2897490441)

As before I haven't tested with Snap (I don't normally use that
framework). It would be helpful if a snapd user/developer could
double-check that this version is still working as expected with Snap,
too.

[ Risks ]
It seems that I was correct to assess the refactoring for app-info
initialization as the highest-risk part of #1105893: that's where these
regressions were found. I asked upstream to avoid this sort of refactoring
on stable-branches whenever possible.

The delta between 1.20.1 and 1.20.3 is minimal and targeted. The larger
diffs in xdp-portal-impl.[ch] are only compiled if using older GLib
(restoring compatibility with bookworm) and should have no effect on
the trixie binary.

I haven't tested with Snap apps, so the Snap-related changes in 1.20.3
are for symmetry with their Flatpak equivalent. They are very narrowly
targeted (2 lines deleted) and could easily be reverted if they somehow
cause a problem.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [ ] attach debdiff against the package in testing
      - the attached debdiff is vs. what was already approved in #1105893
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xdg-desktop-portal_1.20.3+ds-1.diff
Type: text/x-diff
Size: 6861 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-utopia-maintainers/attachments/20250521/32931d31/attachment.diff>