[Pkg-utopia-maintainers] Bug#1121456: cockpit-ws: broken symlinks to non-existing archlinux logos

[Marc Leeman]

Package: cockpit-ws
Version: 346-1
Severity: minor

Dear Maintainer,

After writing some tests cases for our systems, I wrote a test that
checks for broken links is system directories:

00034_test-broken-symlinks    : Check for broken symbolic links in system directories...    [FAIL]
---- Output from 00034_test-broken-symlinks ----
Broken symlinks detected in system directories.
/usr/share/cockpit/branding/arch/logo.png
/usr/share/cockpit/branding/arch/favicon.ico
/usr/share/cockpit/branding/arch/apple-touch-icon.png
--------------------------

The above files are symlinks to non-existing files and these are not
provided by any package.
-------------- next part --------------
Description: Remove broken archlinux logo symlinks
  The debian package has a number of broken symlinks to archlinux logos
  that are not in any package.
Author: Marc Leeman <marc.leeman at gmail.com>
Last-Update: 2025-11-26

Index: cockpit/Makefile.in
===================================================================
--- cockpit.orig/Makefile.in
+++ cockpit/Makefile.in
@@ -5996,11 +5996,6 @@ uninstall-python:
 %.metainfo.xml: %.metainfo.xml.in
 	$(AM_V_GEN) mkdir -p $(dir $@) && msgfmt --xml -d $(top_srcdir)/po --template $< --output $@

-install-data-hook::
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/logo.png
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/apple-touch-icon.png
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/favicon.ico
-
 # Opportunistically use fedora-logos
 install-data-hook::
 	ln -sTfr $(DESTDIR)/usr/share/pixmaps/system-logo-white.png $(DESTDIR)$(centosbrandingdir)/logo.png
Index: cockpit/src/branding/arch/Makefile.am
===================================================================
--- cockpit.orig/src/branding/arch/Makefile.am
+++ cockpit/src/branding/arch/Makefile.am
@@ -3,8 +3,3 @@ archbrandingdir = $(datadir)/cockpit/bra
 dist_archbranding_DATA = \
 	src/branding/arch/branding.css \
 	$(NULL)
-
-install-data-hook::
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/logo.png
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/apple-touch-icon.png
-	ln -sTfr $(DESTDIR)/usr/share/pixmaps/archlinux-logo.png $(DESTDIR)$(archbrandingdir)/favicon.ico