[Pkg-utopia-maintainers] Bug#1133443: cockpit: ftbfs with GCC-16

[Emanuele Rocca]

Hi Martin,

On 2026-04-22 07:55, Martin Pitt wrote:
> > =================================== FAILURES ===================================
> > _____________________________ test_fsread1_errors ______________________________
> > 
> > transport = <test.pytest.mocktransport.MockTransport object at 0xff010723cdd0>
> > tmp_path = PosixPath('/tmp/pytest-of-sbuild/pytest-0/test_fsread1_errors0')
> > 
> >     @pytest.mark.asyncio
> >     async def test_fsread1_errors(transport: MockTransport, tmp_path: Path) -> None:
> > >       await transport.check_open('fsread1', path='/etc/shadow', problem='access-denied')
> > 
> > test/pytest/test_bridge.py:422: 
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> > test/pytest/mocktransport.py:66: in check_open
> >     await self.assert_msg('', command='close', channel=ch, problem=problem, absent_keys=absent_keys,
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> > 
> > self = <test.pytest.mocktransport.MockTransport object at 0xff010723cdd0>
> > expected_channel = '', absent_keys = ()
> > kwargs = {'channel': 'channel.1', 'command': 'close', 'problem': 'access-denied'}
> > msg = {'channel': 'channel.1', 'command': 'done'}
> 
> This is Python code, so totally unrelated to the C compiler. Rather, what this
> unit test assumes is that it doesn't run as root, i.e. that it cannot read
> /etc/shadow. So either you ran the build as root (most probably) or your build
> env has a world-readable /etc/shadow.

The archive rebuild was performed with sbuild using the unshare backend
under a non-root user. However, in order to pull in GCC-16 from
experimental I used the aspcud build dependency resolver. That has
caused a handful of false positives, and cockpit is one of them
unfortunately. The issue can be easily reproduced as follows:

 $ sbuild --build-dep-resolver=aspcud cockpit

Instead of installing systemd, aspcud ends up installing
systemd-standalone-sysusers. The build environment thus has no
/etc/shadow at all.

> I fixed the test in the above PR to skip that bit when running as root.

Glad there was at least some productive outcome. :-)

For the next rebuild I'll avoid using aspcud altogether.

While investigating this issue, I noticed that pytest is only running on
the Arch: all buildds, which are x86. That means that the package is not
tested on any other architecture really. Is this on purpose?

Thanks!
  Emanuele