[Pkg-utopia-maintainers] Bug#1126343: dbus: Mark valgrind-if-available test-only

[Simon McVittie]

Control: tags -1 + moreinfo

On Sat, 24 Jan 2026 at 11:58:37 +0100, Bastian Germann wrote:
>Please mark Build-Depends: valgrind-if-available <!nocheck> so that dbus
>does not make valgrind a key package.

That would be a wrong use of that build-profile. Having valgrind 
installed, or not, changes the contents of the dbus-tests package: it 
uses <valgrind.h> (via dbus/dbus-valgrind-internal.h) to insert 
instrumentation into the binaries in /usr/lib/dbus-1.0/debug-build/ so 
that valgrind will understand libdbus' memory-pool implementation and 
report correctly.

The dependency could probably be <!noinsttest>, though. I see that 
<!nocheck> and <!nodoc> build-deps are ignored for the purposes of 
calculating key packages. Release team: would it make sense to add 
<!noinsttest> to that list?

(Or dbus could vendor a copy of valgrind.h, like glib2.0 does, but 
[insert the standard argument about the pros and cons of vendoring here].)

     smcv