[Pkg-utopia-maintainers] Bug#1136600: udisks2 uses pidof but does not depend on procps

[Gioele Barabucci]

Source: udisks2
Version: 2.11.1-1
Usertags: pidof-without-procps

Dear maintainer(s) of udisks2,

it appears that udisks2 uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of udisks2
  that use `pidof` at runtime;
* via the `Build-Depends:` field of udisks2, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of udisks2, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that udisks2 uses `pidof` due to the following
code snippets:

```
path: udisks2_2.11.1-1/src/tests/dbus-tests/test_19_lsm.py
        # check that lsmd is running
        ret, _out = cls.run_command('pidof lsmd')
        if ret != 0:
            udiskstestcase.UdisksTestCase.tearDownClass()
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci