Bug#709031: vdr-plugin-xine: FTBFS with current vdr

[Colin Watson]

Package: vdr-plugin-xine
Version: 0.9.4-7
Severity: serious
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu saucy

vdr-plugin-xine fails to build with the current vdr in unstable, as
shown in this Ubuntu build log:

  g++ -g -O3 -Wall -Woverloaded-virtual -c -D_GNU_SOURCE -DPLUGIN_NAME_I18N='"xine"' -DFIFO_DIR=\"/tmp/vdr-xine\" -DVERIFY_BITMAP_DIRTY=0 `pkg-config --cflags libxine`  -I/usr/include/vdr/include xineDevice.c
  [...]
  xineDevice.c: In member function 'virtual void PluginXine::cXineDevice::StillPicture(const uchar*, int)':
  xineDevice.c:1203:36: error: 'class cPatPmtParser' has no member named 'PmtPid'
         else if (pid == patPmtParser.PmtPid())
                                      ^
  xineDevice.c:1403:1: warning: narrowing conversion of '(vdr172::cRemux::IsFrameH264(Data, Length) ? 10 : 183)' from 'int' to 'uchar {aka unsigned char}' inside { } is ill-formed in C++11 [-Wnarrowing]
   };
   ^
  xineDevice.c: In member function 'void PluginXine::cXineDevice::mainMenuTrampoline()':
  xineDevice.c:4230:79: warning: ignoring return value of 'int asprintf(char**, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
         ::asprintf(&msg, tr("Switching primary DVB to %s..."), m_plugin->Name());
                                                                                 ^
  xineDevice.c:4241:82: warning: ignoring return value of 'int asprintf(char**, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
         ::asprintf(&msg, tr("Switched primary DVB back from %s"), m_plugin->Name());
                                                                                    ^
  [...]
  make[2]: *** [xineDevice.o] Error 1

I looked into fixing this, but I don't know the code well enough.  There
is a definition of cPatPmtParser::PmtPid, but it's inside an "#if 0"
block, along with the rest of class cPatPmtParser.  In fact there are
several fairly large "#if 0" blocks; this is the sort of thing I'd
expect to see in somebody's experimental branch, not in released code.
Furthermore the upstream web site appears to have vanished and so I
can't trace through version control to try to work out what's going on.
Perhaps you have a better idea?

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]