Bug#716413: [Mayhem] Bug report on dvb-apps: tzap crashes with exit status 139

[Bernhard Übelacker]

found 716413 1.1.1+rev1500-1
stop



Hello,
tzap crashes because of a strlen(0) because homedir/$HOME is not set.

Minimal statement to reproduce:
	$ env -i tzap 1

Following patch exits immediately after the
message, therefore avoids the crash.

Kind regards,
Bernhard



--- tzap.c.orig	2013-05-13 12:19:02.000000000 +0200
+++ tzap.c	2015-05-06 21:36:40.094538626 +0200
@@ -577,9 +577,11 @@ int main(int argc, char **argv)
 		fprintf (stderr,"using '%s' and '%s'\n", FRONTEND_DEV, DEMUX_DEV);
 
 	if (!confname) {
-		int len = strlen(homedir) + strlen(CHANNEL_FILE) + 18;
-		if (!homedir)
+		if (!homedir) {
 			ERROR ("$HOME not set");
+			return -1;
+		}
+		int len = strlen(homedir) + strlen(CHANNEL_FILE) + 18;
 		confname = malloc (len);
 		snprintf(confname, len, "%s/.tzap/%i/%s", homedir, adapter, CHANNEL_FILE);
 		if (access (confname, R_OK))