Bug#872497: vdr-plugin-games FTBFS with vdr 2.3.8

[Gianfranco Costamagna]

On Thu, 17 Aug 2017 23:17:07 +0300 Adrian Bunk <bunk at debian.org> wrote:
> Source: vdr-plugin-games
> Version: 0.6.3-46
> Severity: serious
> Tags: buster sid
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/vdr-plugin-games.html
> 
> ...
> g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -fdebug-prefix-map=/build/vdr-2.3.8=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wdate-time -D_FORTIFY_SOURCE=2  -c -DVERSION=\"0.6.3\" -D_GNU_SOURCE -DVDRVERSNUM=20308 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -fdebug-prefix-map=/build/vdr-2.3.8=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -I/usr/include/vdr/include  -I/usr/include/vdr/include -c screen.cpp -o screen.o
> screen.cpp: In function 'int Scr::palette(int)':
> screen.cpp:90:23: error: 'cBitmap* cOsd::GetBitmap(int)' is protected within this context
>     screen->GetBitmap(0)->SetColor(i, PALETTE(i));
>                        ^
> In file included from screen.cpp:8:0:
> /usr/include/vdr/osd.h:792:12: note: declared protected here
>    cBitmap *GetBitmap(int Area);
>             ^~~~~~~~~
> Makefile:95: recipe for target 'screen.o' failed
> make[3]: *** [screen.o] Error 1
> 
> 

patch attached and uploaded
-------------- next part --------------
diff -Nru vdr-plugin-games-0.6.3/debian/changelog vdr-plugin-games-0.6.3/debian/changelog
--- vdr-plugin-games-0.6.3/debian/changelog	2015-09-22 20:55:36.000000000 +0200
+++ vdr-plugin-games-0.6.3/debian/changelog	2017-09-16 11:22:32.000000000 +0200
@@ -1,3 +1,11 @@
+vdr-plugin-games (0.6.3-46.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * #define DEPRECATED_GETBITMAP to make it build.
+    (plugin needs porting) Closes: #872497
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org>  Sat, 16 Sep 2017 11:22:32 +0200
+
 vdr-plugin-games (0.6.3-46) unstable; urgency=medium
 
   * Now supporting the /etc/vdr/conf.d mechanism
diff -Nru vdr-plugin-games-0.6.3/debian/patches/series vdr-plugin-games-0.6.3/debian/patches/series
--- vdr-plugin-games-0.6.3/debian/patches/series	2015-09-22 20:55:36.000000000 +0200
+++ vdr-plugin-games-0.6.3/debian/patches/series	2017-09-16 11:22:32.000000000 +0200
@@ -2,3 +2,4 @@
 03_games-0.6.3-fix-INCLUDES.patch
 04_gcc-4.6.patch
 flags.patch
+vdr.patch
diff -Nru vdr-plugin-games-0.6.3/debian/patches/vdr.patch vdr-plugin-games-0.6.3/debian/patches/vdr.patch
--- vdr-plugin-games-0.6.3/debian/patches/vdr.patch	1970-01-01 01:00:00.000000000 +0100
+++ vdr-plugin-games-0.6.3/debian/patches/vdr.patch	2017-09-16 11:22:32.000000000 +0200
@@ -0,0 +1,17 @@
+Description:
+   * #define DEPRECATED_GETBITMAP to make it build.
+     (plugin needs porting) See: #872497
+Author: Gianfranco Costamagna <locutusofborg at debian.org>
+Last-Update: 2017-09-16
+
+--- vdr-plugin-games-0.6.3.orig/screen.cpp
++++ vdr-plugin-games-0.6.3/screen.cpp
+@@ -2,6 +2,8 @@
+ #include <unistd.h>
+ #include <stdlib.h>
+ 
++#define DEPRECATED_GETBITMAP 1
++
+ #ifdef SDL
+ 	#include <SDL.h>
+ #else