Bug#964223: linuxtv-dvb-apps: FTBFS with glibc 2.31 (uses removed stime function)

[Aurelien Jarno]

On 2020-07-19 19:35, Aurelien Jarno wrote:
> control: tag -1 + pending
> 
> Dear maintainer,
> 
> On 2020-07-13 23:44, Aurelien Jarno wrote:
> > control: severity -1 serious
> > 
> > On 2020-07-03 22:27, Aurelien Jarno wrote:
> > > Source: linuxtv-dvb-apps
> > > Version: 1.1.1+rev1500-1.2
> > > Severity: important
> > > Tags: patch upstream
> > > 
> > > linuxtv-dvb-apps fails to build from source with glibc 2.31:
> > > 
> > > | CC dvbdate
> > > | dvbdate.c: In function ‘set_time’:
> > > | dvbdate.c:312:6: warning: implicit declaration of function ‘stime’; did you mean ‘ctime’? [-Wimplicit-function-declaration]
> > > |   312 |  if (stime(new_time)) {
> > > |       |      ^~~~~
> > > |       |      ctime
> > > | /usr/bin/ld: /tmp/cchQDddv.o: in function `set_time':
> > > | ./util/dvbdate/dvbdate.c:312: undefined reference to `stime'
> > > | /usr/bin/ld: ./util/dvbdate/dvbdate.c:312: undefined reference to `stime'
> > > | collect2: error: ld returned 1 exit status
> > > | make[3]: *** [../../Make.rules:82: dvbdate] Error 1
> > > | make[3]: Leaving directory '/<<PKGBUILDDIR>>/util/dvbdate'
> > > | make[2]: *** [Makefile:10: all] Error 2
> > > | make[2]: Leaving directory '/<<PKGBUILDDIR>>/util'
> > > | make[1]: *** [Makefile:14: all] Error 2
> > > | make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> > > | dh_auto_build: error: make -j1 returned exit code 2
> > > | make: *** [debian/rules:4: build] Error 25
> > > | dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
> > > 
> > > The full build log is available there:
> > > http://qa-logs.debian.net/2020/06/24/linuxtv-dvb-apps_1.1.1+rev1500-1.2_unstable_glibc-exp.log
> > > 
> > > The stime function has been marked as obsolete for some time, and since
> > > glibc 2.31 it is no longer available to newly linked binaries. The
> > > clock_settime function should be used instead.
> > > 
> > > You will find attached a patch fixing that. It would be nice if it can
> > > be fixed relatively soon so that we can start the transition.
> > > 
> > 
> > Note that glibc 2.31 is now in unstable. I am therefore increasing the
> > severity to serious.
> 
> I have prepared an NMU for linuxtv-dvb-apps (versioned as
> 1.1.1+rev1500-1.3), fixing the build issue with glibc 2.31. You will
> find the diff attached. I have uploaded it to DELAYED/7. Please feel
> free to tell me if I should delay it longer or cancel it altogether.

Unfortunately the NMU failed to build as in the meantime GCC 10 became
the default compiler and linuxtv-dvb-apps doesn't build with this
version due to bug #957492.

I have therefore done a second NMU, versioned 1.1.1+rev1500-1.4, and
uploaded directly to the archive (i.e. *not* through the delayed queue).
You will find the diff attached.

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                 http://www.aurel32.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linuxtv-dvb-apps.NMU.2.diff
Type: text/x-diff
Size: 1994 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-vdr-dvb-devel/attachments/20200726/2ca42ecf/attachment-0005.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-vdr-dvb-devel/attachments/20200726/2ca42ecf/attachment-0005.sig>