Bug#1110492: vdr-plugin-xineliboutput FTCBFS: multiple reasons

[Helmut Grohne]

Hi Nilesh,

On Thu, Aug 07, 2025 at 04:26:24AM +0530, Nilesh Patra wrote:
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -46,6 +46,7 @@
> + CXX      ?= g++
> + CC       ?= gcc 
> + OPTFLAGS ?= 
> ++PKG_CONFIG ?= pkg-config

It's not clear from the patch context whether CC_FOR_BUILD is
initialized anywhere. If it isn't, please add

    CC_FOR_BUILD ?= $(CC)

to avoid regressing native builds.

>  override_dh_auto_build:
> -	dh_auto_build -- all $(MAKE_OPTIONS)
> +	dh_auto_build -- all $(MAKE_OPTIONS) CC="$(CC)" CXX="$(CXX)" CC_FOR_BUILD="$(CC_FOR_BUILD)" PKG_CONFIG="$(PKG_CONFIG)"

It feels wrong to have to pass these to the Makefile after having passed
them to configure. The usual convention is that configure records the
values passed somewhere for make to pick up. Don't get me wrong, it's
not a regression of the patch at hand, but an upstream aspect.

You may also leverage debhelper for passing many of these by using

    dh_auto_build --buildsystem=makefile -- all ...

as there are provisions to add CC, CXX, PKG_CONFIG and others to the
make invocation unless a higher level buildsystem (e.g. autoconf) is in
use. By forcing the lower level buildsystem, the passing is activated.

Helmut