Bug#264004: openh323: FTBFS with gcc-3.4: `virtual H323Transaction::Response H323GatekeeperRRQ::OnHandlePDU()' is protected

[Andreas Jochens]

Package: openh323
Severity: normal
Tags: patch

When building 'openh323' with gcc-3.4 I get the following error:

g++  -DP_USE_PRAGMA -fno-rtti -ffunction-sections -fdata-sections -D_REENTRANT -Wall  -DP_64BIT -g -D_DEBUG -DNDEBUG -DPTRACING -I/openh323-1.13.5/include -DHAS_OSS -DPTRACING -I/usr/share/pwlib//include  -fPIC -DPIC -x c++ -c gkserver.cxx -o /openh323-1.13.5/lib/obj_linux_x86_64_d/gkserver.o
In file included from gkserver.cxx:590:
/openh323-1.13.5/include/gkserver.h:434: error: `virtual H323Transaction::Response H323GatekeeperRRQ::OnHandlePDU()' is protected
/openh323-1.13.5/include/gkserver.h:1946: error: within this context
gkserver.cxx: In member function `virtual void H323GatekeeperServer::RemoveCall(H323GatekeeperCall*)':
gkserver.cxx:3775: warning: right-hand operand of comma has no effect
make[4]: *** [/openh323-1.13.5/lib/obj_linux_x86_64_d/gkserver.o] Error 1
make[4]: Leaving directory `/openh323-1.13.5/src'

With the attached patch 'openh323' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/openh323-1.13.5/include/gkserver.h ./include/gkserver.h
--- ../tmp-orig/openh323-1.13.5/include/gkserver.h	2004-03-31 09:16:22.000000000 +0200
+++ ./include/gkserver.h	2004-08-06 19:38:49.265768959 +0200
@@ -430,7 +430,7 @@
     H225_RegistrationConfirm & rcf;
     H225_RegistrationReject  & rrj;
 
-  protected:
+//  protected:
     virtual Response OnHandlePDU();
 };