Bug#209405: marked as done (We should be dynamically linking against Debian's libgsm and libspeex)

Debian Bug Tracking System owner@bugs.debian.org
Sun, 27 Jun 2004 07:03:07 -0700


Your message dated Sun, 27 Jun 2004 15:51:32 +0200
with message-id <20040627135132.GA28322@gimli.jaimedelamo.eu.org>
and subject line ACK of NMU
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 9 Sep 2003 18:46:04 +0000
>From manty@debian.org Tue Sep 09 13:46:02 2003
Return-path: <manty@debian.org>
Received: from 204.red-213-96-224.pooles.rima-tde.net (pul.beta.es) [213.96.224.204] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19wnV3-0005HN-00; Tue, 09 Sep 2003 13:46:01 -0500
Received: by pul.beta.es (Postfix, from userid 1000)
	id 280AEF946; Tue,  9 Sep 2003 20:46:00 +0200 (CEST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Santiago Garcia Mantinan <manty@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: We should be dynamically linking against Debian's libgsm and libspeex
X-Mailer: reportbug 2.27
Date: Tue, 09 Sep 2003 20:45:59 +0200
Message-Id: <20030909184600.280AEF946@pul.beta.es>
X-BadReturnPath: manty@pul.beta.es rewritten as manty@debian.org
  using "From" header
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-4.8 required=4.0
	tests=BAYES_20,HAS_PACKAGE,RCVD_IN_RFCI
	version=2.53-bugs.debian.org_2003_8_27
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_8_27 (1.174.2.15-2003-03-30-exp)

Package: openh323
Version: 1.12.2-1
Severity: wishlist
Tags: sid

Hi!

A long time ago a whishlist bug like this one was filled against openh323 so
that we used Debian's libgsm lib instead of openh323 internal one (which is
just a copy of the one that Debian has but without a lot of fixes). We had
to recompile libgsm to be compatible with MS mode, but once that was done,
with help from Miguel Rodriguez (migras), it was done.

After that, the openh323 guys included speex support in h323, first by
dynamically linking to the libspeex libs, but then including this libs into
openh323 itself, so we got to the same problem and we had to patch openh323
sources again to dynamically link to our libspeex libs.

I really think it would be a good idea if we could continue to use our
versions of libgsm and libspeex instead of those in the openh323 package,
this means smaller packages more shared memory with other apps using libgsm
or libspeex, more coherent Debian packages, ...

You can visit the original bug to use Debian's libgsm here:
http://bugs.debian.org/103538

What we had to use for patching openh323 to use Debian's libgsm and libspeex
was more or less what I descrive below, hope this helps you some way to do
it again with current version.

1- The libs and the debug version of the programs should be linked against
libgsm, this used to mean:

+ifeq ($(P_SHAREDLIB),0)
+LDLIBS += -lgsm
+endif
+
+EXTLIBS += -lgsm

2- Similar patch but for speex (s/gsm/speex/) was applied.

3- All the stuff related to the openh323 libgsm should disappear, which
mainly meaned to remove the definition of GSM_DIR and all the stuff that was
relating to that variable, like GSM_SRCDIR, GSM_INCDIR and all the things
relating these that was appended to HEADER_FILES and COMMON_SOURCES. Then
remove the "Build rules for the GSM codec" which heavily relays on all this
variables I have mentioned, and make this change in gsmcodec.cxx and
mscodecs.cxx:
-#include "gsm/inc/gsm.h"
+#include <gsm.h>

4- Similar thing as in point 3 but for speex used to be done, only that
speex doesn't have the mscodecs.cxx entry.

5- In the building rules a -I/usr/include/gsm had to be added when
compiling.

Well, guess that is all, maybe you can see that better searching in a case
insensitive way for gsm and speex in openh323_1.11.7-5.diff.gz.

Hope that helps, if you don't understand something just tell me.

Regards...

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux pul 2.4.22 #1 Fri Sep 5 22:48:01 CEST 2003 i686
Locale: LANG=C, LC_CTYPE=C


---------------------------------------
Received: (at 209405-done) by bugs.debian.org; 27 Jun 2004 13:51:37 +0000
>From jose@gimli.jaimedelamo.eu.org Sun Jun 27 06:51:37 2004
Return-path: <jose@gimli.jaimedelamo.eu.org>
Received: from 172.red-81-36-28.pooles.rima-tde.net (hal9000) [81.36.28.172] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bea4H-0001y8-00; Sun, 27 Jun 2004 06:51:37 -0700
Received: from [192.168.1.10] (helo=localhost)
	by hal9000 with esmtp (Exim 4.34)
	id 1Bea4E-0003Yg-5A; Sun, 27 Jun 2004 15:51:34 +0200
Received: by localhost (Postfix, from userid 1000)
	id BB6B1DF96C; Sun, 27 Jun 2004 15:51:32 +0200 (CEST)
Date: Sun, 27 Jun 2004 15:51:32 +0200
From: Jose Carlos Garcia Sogo <jsogo@debian.org>
To: 209151-done@bugs.debian.org, 209405-done@bugs.debian.org
Subject: ACK of NMU
Message-ID: <20040627135132.GA28322@gimli.jaimedelamo.eu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs"
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040523i
Delivered-To: 209405-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 2


--82I3+IH0IqGh5yIs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Following versions of this package ACKed the NMU closing these bugs.

Cheers,

--
 Jose Carlos Garcia Sogo
    jsogo@debian.org

--82I3+IH0IqGh5yIs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA3tDkS+BYJZB4jhERAnBfAJ0YyFHBF6dGt1TcJQOKle6yMRW/wgCgkZ+9
RZWuK9DWUm5PKJkqr8fMjWc=
=rzS4
-----END PGP SIGNATURE-----

--82I3+IH0IqGh5yIs--