Bug#300938: marked as done (siproxd: FTBFS (amd64/gcc-4.0): too few arguments to function 'osip_message_parse')

Debian Bug Tracking System owner@bugs.debian.org
Tue, 03 May 2005 08:18:36 -0700


Your message dated Tue, 3 May 2005 11:13:55 -0400 (EDT)
with message-id <Pine.LNX.4.62.0505031112400.18857@mirrorlynx.com>
and subject line siproxd
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Mar 2005 19:55:39 +0000
>From aj@andaco.de Tue Mar 22 11:55:38 2005
Return-path: <aj@andaco.de>
Received: from c223012.adsl.hansenet.de (localhost.localdomain) [213.39.223.12] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DDpTV-0000kH-00; Tue, 22 Mar 2005 11:55:38 -0800
Received: from aj by localhost.localdomain with local (Exim 4.44)
	id 1DDpTU-0001fU-He; Tue, 22 Mar 2005 20:55:36 +0100
To: Debian Bug Tracking System <submit@bugs.debian.org>
From: Andreas Jochens <aj@andaco.de>
Subject: siproxd: FTBFS (amd64/gcc-4.0): too few arguments to function 'osip_message_parse'
Message-Id: <E1DDpTU-0001fU-He@localhost.localdomain>
Date: Tue, 22 Mar 2005 20:55:36 +0100
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: siproxd
Severity: normal
Tags: patch

When building 'siproxd' on amd64 with gcc-4.0,
I get the following error:

if cc -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include -Wall -D_GNU_SOURCE -DBUILDSTR="\"`cat .buildno`\"" -g -Wall -O2 -pthread -D_POSIX_THREAD_SAFE_FUNCTIONS -MT siproxd.o -MD -MP -MF ".deps/siproxd.Tpo" \
  -c -o siproxd.o `test -f 'siproxd.c' || echo './'`siproxd.c; \
then mv -f ".deps/siproxd.Tpo" ".deps/siproxd.Po"; \
else rm -f ".deps/siproxd.Tpo"; exit 1; \
fi
siproxd.c: In function 'main':
siproxd.c:332: error: too few arguments to function 'osip_message_parse'
make[3]: *** [siproxd.o] Error 1
make[3]: Leaving directory `/siproxd-0.5.10/src'

With the attached patch 'siproxd' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/siproxd-0.5.10/src/proxy.c ./src/proxy.c
--- ../tmp-orig/siproxd-0.5.10/src/proxy.c	2005-01-24 20:12:40.000000000 +0100
+++ ./src/proxy.c	2005-03-22 16:53:40.606097320 +0100
@@ -516,7 +516,7 @@
    * RFC 3261, Section 16.6 step 10
    * Proxy Behavior - Forward the new request
    */
-   sts = osip_message_to_str(request, &buffer);
+   sts = osip_message_to_str(request, &buffer, strlen(buffer));
    if (sts != 0) {
       ERROR("proxy_request: osip_message_to_str failed");
       return STS_FAILURE;
@@ -910,7 +910,7 @@
       }
    }
 
-   sts = osip_message_to_str(response, &buffer);
+   sts = osip_message_to_str(response, &buffer, strlen(buffer));
    if (sts != 0) {
       ERROR("proxy_response: osip_message_to_str failed");
       return STS_FAILURE;
@@ -966,7 +966,7 @@
       }
    }
 
-   sts = osip_body_to_str(body, &bodybuff);
+   sts = osip_body_to_str(body, &bodybuff, strlen(&bodybuff));
    sts = sdp_message_init(&sdp);
    sts = sdp_message_parse (sdp, bodybuff);
    osip_free(bodybuff);
@@ -981,7 +981,7 @@
 { /* just dump the buffer */
    char *tmp, *tmp2;
    sts = osip_message_get_body(mymsg, 0, &body);
-   sts = osip_body_to_str(body, &tmp);
+   sts = osip_body_to_str(body, &tmp, strlen(tmp));
    osip_content_length_to_str(mymsg->content_length, &tmp2);
    DEBUG("Body before rewrite (clen=%s, strlen=%i):\n%s\n----",
          tmp2, strlen(tmp), tmp);
@@ -1210,7 +1210,7 @@
    sdp_message_free(sdp);
 
    /* include new body */
-   osip_message_set_body(mymsg, bodybuff);
+   osip_message_set_body(mymsg, bodybuff, strlen(bodybuff));
 
    /* free content length resource and include new one*/
    osip_content_length_free(mymsg->content_length);
@@ -1225,7 +1225,7 @@
 { /* just dump the buffer */
    char *tmp, *tmp2;
    sts = osip_message_get_body(mymsg, 0, &body);
-   sts = osip_body_to_str(body, &tmp);
+   sts = osip_body_to_str(body, &tmp, strlen(&tmp));
    osip_content_length_to_str(mymsg->content_length, &tmp2);
    DEBUG("Body after rewrite (clen=%s, strlen=%i):\n%s\n----",
          tmp2, strlen(tmp), tmp);
diff -urN ../tmp-orig/siproxd-0.5.10/src/register.c ./src/register.c
--- ../tmp-orig/siproxd-0.5.10/src/register.c	2005-01-08 11:05:12.000000000 +0100
+++ ./src/register.c	2005-03-22 16:53:57.293874812 +0100
@@ -550,7 +550,7 @@
       }
    }   
 
-   sts = osip_message_to_str(response, &buffer);
+   sts = osip_message_to_str(response, &buffer, strlen(&buffer));
    if (sts != 0) {
       ERROR("register_response: msg_2char failed");
       return STS_FAILURE;
diff -urN ../tmp-orig/siproxd-0.5.10/src/sip_utils.c ./src/sip_utils.c
--- ../tmp-orig/siproxd-0.5.10/src/sip_utils.c	2005-01-08 11:05:13.000000000 +0100
+++ ./src/sip_utils.c	2005-03-22 16:54:44.297798071 +0100
@@ -563,7 +563,7 @@
       }
    }   
 
-   sts = osip_message_to_str(response, &buffer);
+   sts = osip_message_to_str(response, &buffer, strlen(&buffer));
    if (sts != 0) {
       ERROR("sip_gen_response: msg_2char failed");
       return STS_FAILURE;
diff -urN ../tmp-orig/siproxd-0.5.10/src/siproxd.c ./src/siproxd.c
--- ../tmp-orig/siproxd-0.5.10/src/siproxd.c	2005-01-08 11:41:46.000000000 +0100
+++ ./src/siproxd.c	2005-03-22 16:51:10.871011947 +0100
@@ -321,7 +321,7 @@
        * Proxy Behavior - Request Validation - Reasonable Syntax
        * (parse the received message)
        */
-      sts=osip_message_parse(ticket.sipmsg, buff);
+      sts=osip_message_parse(ticket.sipmsg, buff, strlen(buff));
       if (sts != 0) {
          ERROR("osip_message_parse() failed... this is not good");
          DUMP_BUFFER(-1, buff, i);

---------------------------------------
Received: (at 300938-done) by bugs.debian.org; 3 May 2005 15:11:03 +0000
>From dan@mirrorlynx.com Tue May 03 08:11:03 2005
Return-path: <dan@mirrorlynx.com>
Received: from outbound.mailhop.org [63.208.196.171] (mailnull)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DSz39-0003W8-00; Tue, 03 May 2005 08:11:03 -0700
Received: from pool-68-238-242-169.phlapa.fios.verizon.net ([68.238.242.169] helo=mirrorlynx.com)
	by outbound.mailhop.org with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.44)
	id 1DSz38-0003zG-KJ
	for 300938-done@bugs.debian.org; Tue, 03 May 2005 11:11:02 -0400
Received: from dan (helo=localhost)
	by mirrorlynx.com with local-esmtp (Exim 4.34)
	id 1DSz5v-0004xd-UX
	for 300938-done@bugs.debian.org; Tue, 03 May 2005 11:13:56 -0400
Date: Tue, 3 May 2005 11:13:55 -0400 (EDT)
From: Dan Weber <dan@mirrorlynx.com>
To: 300938-done@bugs.debian.org
Message-ID: <Pine.LNX.4.62.0505031112400.18857@mirrorlynx.com>
MIME-Version: 1.0
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Rcpt-To: 300938-done@bugs.debian.org
X-SA-Exim-Mail-From: dan@mirrorlynx.com
Subject: siproxd
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-SA-Exim-Version: 4.1 (built Tue, 17 Aug 2004 11:06:07 +0200)
X-SA-Exim-Scanned: Yes (on mirrorlynx.com)
X-Mail-Handler: MailHop Outbound by DynDNS.org
X-Originating-IP: 68.238.242.169
X-Report-Abuse-To: abuse@dyndns.org (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information)
X-MHO-User: DanWeber1
Delivered-To: 300938-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=0.5 required=4.0 tests=BAYES_30,ONEWORD autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

NMU approved.

Dan