asterisk-addons

[Jose Carlos Garcia Sogo]

On Fri, Jan 06, 2006 at 10:15:28PM +0200, Tzafrir Cohen wrote:
> Hi
> 
> I've just loaded my version of the package asterisk-addons. The tarball
> itself could be downloaded from
> http://ftp.digium.com/pub/asterisk/asterisk-addons-1.2.1.tar.gz .
> 
> Problems with current package:
> 
> 0. svn-buildpackage fails with strange errors ('fakeroot debian/rules
>    clean' fails to pass dh_testroot). It also seems that the building is
>    not done in an extracted tarball under the build-root, but rather
>    in the current directory.
> 
>    Can anybody take a look?

     This is a strange error I have suffered sometimes with openh323 and
     pwlib sources. I don't know where the error is, as it usually just
     vanishes.

> 1. copyrights. Specifically: all the files there are GPL. Is it OK to
>    link GPL with openssl and openh323?

     Not. You cannot link a GPL program with openssl and/or openh323.
     You need a statement from copyright holders allowing that. If you
     Google for "openssl debian gpl" I think you will find the statement
     you want (I am offline at the moment of writing this).
     For openh323 you can take a look at gnomemeeting's one.
 
> 2. One binary package or several packages?
>    mysql has an external dependency on mysql libs. sqlite3 should have
>    one as well. Furthermore, the packages may be conflicting. 
> 
>    Thus I chose several binary packages for each.

     Seems a right approach to me. This will allow people to install
     only libs for what DB engine is going to use.

>    
> 3. I have not package app_saycountpl . Anybody needs it? Isn't its
>    functionality superceded by SayNumber? I'd wait for a bug report.
> 
> 4. Dependency on asterisk: 
>    I don't think there is any need to make asterisk-addons depend on
>    asterisk of the same version. Much like asterisk-sounds,
>    asterisk-addons get their version bumped on almost any new release of
>    asterisk, but the content practically doesn't change.
> 
>    There should be a changelog on http://dev.asteriskdocs.org/ . But
>    that site appears to be taken by aliens at the moment.
> 
> Basically I think that those modules need to depend on "asterisk 
> interface" of a specific version, and the version number of that 
> interface should be bumped whenever a change in Asterisk breaks modules. 
> This is much like the kernel version number.
> 
> This applies to any other out-of-tree module: the spandsp modules (fax
> and dtmftotext), chan_oh323, and probably some others.

  Yes, the problem is defining that interface. I mean, asterisk upstream
  should be the one defining that, and changing it only when needed,
  clearly stating that. If not, we will have to check every module
  depending on asterisk to see if it needs a recompile or not, or wait
  for some user to report us a bug.

  Cheers,

-- 
Jose Carlos Garcia Sogo
   jsogo at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20060106/5a396d8f/attachment.pgp