Bug#357959: FTBFS with G++ 4.1: extra qualification

[Martin Michlmayr]

Package: kphone
Version: 1:4.2-5
Severity: important
Tags: patch

Your package fails to build with G++ 4.1.  I'm filing this bug as
important for now, but when 4.1 will be the default compiler in
unstable (probably in a few weeks) I'll upgrade this to serious.

A patch is below.  I think KDE has fixed all 4.1 issues already; if
not, please forward this patch upstream.


> Automatic build of kphone_1:4.2-5 on bigsur by sbuild/mips 1.106
...
> g++ -I/usr/share/qt3/include -Wall -O3 -I. -I../gsm -I../ilbc -I../dissipate2 -DHAVE_CONFIG_H -DSHARE_DIR=\"/usr/share/apps/kphone\" -DPO_DIR=\"/usr/share/kphone/translations//\"  -c -o dspoutalsa.o dspoutalsa.cpp
> dspoutalsa.cpp: In member function 'virtual bool DspOutAlsa::openDevice(DspOut::DeviceMode)':
> dspoutalsa.cpp:116: warning: format '%d' expects type 'int', but argument 3 has type 'snd_pcm_uframes_t'
> dspoutalsa.cpp:116: warning: format '%d' expects type 'int', but argument 4 has type 'snd_pcm_uframes_t'
> g++ -I/usr/share/qt3/include -Wall -O3 -I. -I../gsm -I../ilbc -I../dissipate2 -DHAVE_CONFIG_H -DSHARE_DIR=\"/usr/share/apps/kphone\" -DPO_DIR=\"/usr/share/kphone/translations//\"  -c -o main.o main.cpp
> /usr/share/qt3/include/qxml.h:224: warning: 'class QXmlReader' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:407: warning: 'class QXmlContentHandler' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:424: warning: 'class QXmlErrorHandler' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:433: warning: 'class QXmlDTDHandler' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:441: warning: 'class QXmlEntityResolver' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:448: warning: 'class QXmlLexicalHandler' has virtual functions but non-virtual destructor
> /usr/share/qt3/include/qxml.h:461: warning: 'class QXmlDeclHandler' has virtual functions but non-virtual destructor
> kcallwidget.h:70: error: extra qualification 'KCallWidget::' on member 'setDTMFSender'
> kphoneview.h:57: error: extra qualification 'KPhoneView::' on member 'DoCall'
> make[2]: *** [main.o] Error 1


--- ./kphone/kphoneview.h~	2006-03-20 13:57:59.000000000 +0000
+++ ./kphone/kphoneview.h	2006-03-20 13:58:06.000000000 +0000
@@ -54,7 +54,7 @@
 	QString getStunSrv( void );
 	void kphoneQuit( void );
 	bool getState( void );
-	KCallWidget *KPhoneView::DoCall( QString num, SipCall::CallType ctype );
+	KCallWidget *DoCall( QString num, SipCall::CallType ctype );
 
 signals:
 	void stateChanged( void );
--- ./kphone/kcallwidget.h~	2006-03-20 13:58:15.000000000 +0000
+++ ./kphone/kcallwidget.h	2006-03-20 13:58:20.000000000 +0000
@@ -67,7 +67,7 @@
 	void clickHangup( void );
 	void setHide( void );
 	bool isHided( void ) const { return hided; }
-	void KCallWidget::setDTMFSender( QString &s );
+	void setDTMFSender( QString &s );
 
 public slots:
 	void pleaseDial( const SipUri &dialuri );

-- 
Martin Michlmayr
http://www.cyrius.com/