better way to handle patches
Caio Begotti
caio at ueberalles.net
Mon May 15 19:22:41 UTC 2006
On Monday 15 May 2006 15:38, Tzafrir Cohen wrote:
> (that part is quite rewritten in trunk, isn't it?)
Sorry, trunk from Digium or Pkg-Voip? I didn't get it.
> Is "br" the language name to use? It seems that "pt_br" is preffered.
> You also seem to use "pt-de" in the patch to sayunixtime.c .
Although the most common for localization stuff would be pt_BR, "br" is the
preferred term for Brazilian Portuguese in Asterisk, AFAIK. The "pt-de"
things is actually one of some new audio messages required for a proper
pronounce in our portuguese variant. That specific audio means "of" or
something like that (in english it's not used to say dates or time).
> As this part is being rewritten, I'm not sure those patches would be
> welcomed in the main asterisk Mantis. Anyway, unless they are to
> conflict with other patches, and if they solve real-world problems, I'm
> for them.
What you mean by "rewritten"? VoiceMail(), sayunixtime.so and the 'say' core?
Celso (the original author) said yesterday to me that he's going to attach it
in some Mantis report and wait the commit. But you know, it may takes a lot
of time, even it's being really important for portuguese speakers.
Regards,
--
caio[1982] begotti
http://caio.ueberalles.net
More information about the Pkg-voip-maintainers
mailing list