op-panel on pkg-voip

[Alejandro Ríos P.]

Hello again.

El sáb, 27-05-2006 a las 10:36 +0300, Tzafrir Cohen escribió:
> What do youthink about the post-inst script of the package freepbx-panel ?
> (That package has the op-panel wrapper parts for freepbx)
> 
> http://svn.debian.org/wsvn/pkg-voip/freepbx/trunk/debian/freepbx-panel.postinst?op=file&rev=0&sc=0
> 

I would make a couple changes to the update-alternatives command:

1. Lets use a /etc/op-panel subdirectory for each alternative (i.e.
asternic, freepbx and destar), just to make it more readable.

2. I think we should use an alternatives-group to handle all op-panel
config files:  op_server.cfg, op_buttons.cfg, op_astdb.cfg and
op_style.cfg

This way, I propose changing the command to this:

update-alternatives --install /etc/op-panel/op_server.cfg
op-panel /etc/op-panel/freepbx/op_server_freepbx.cfg 80 \
--slave /etc/op-panel/op_buttons.cfg
op-buttons-cfg /etc/op-panel/freepbx/op_buttons_freepbx.cfg \
--slave /etc/op-panel/op_astdb.cfg
op-astdb-cfg /etc/op-panel/freepbx/op_astdb_freepbx.cfg \
--slave /etc/op-panel/op_style.cfg
op-style-cfg /etc/op-panel/freepbx/op_style_freepbx.cfg

We also have to make op-panel and destar use a similar
update-alternatives command on postinst and prerm, but with different
priority, so at the end we would have:

$ update-alternatives --display op-panel
op-panel - status is auto.
 link currently points to /etc/op-panel/asternic/op_server_asternic.cfg
/etc/op-panel/asternic/op_server_asternic.cfg - priority 100
 slave op-style-cfg: /etc/op-panel/asternic/op_style_asternic.cfg
 slave op-astdb-cfg: /etc/op-panel/asternic/op_astdb_asternic.cfg
 slave op-buttons-cfg: /etc/op-panel/asternic/op_buttons_asternic.cfg
/etc/op-panel/destar/op_server_destar.cfg - priority 80
 slave op-style-cfg: /etc/op-panel/destar/op_style_destar.cfg
 slave op-astdb-cfg: /etc/op-panel/destar/op_astdb_destar.cfg
 slave op-buttons-cfg: /etc/op-panel/destar/op_buttons_destar.cfg
/etc/op-panel/freepbx/op_server_freepbx.cfg - priority 50
 slave op-astdb-cfg: /etc/op-panel/freepbx/op_astdb_freepbx.cfg
 slave op-buttons-cfg: /etc/op-panel/freepbx/op_buttons_freepbx.cfg
Current `best' version is /etc/op-panel/asternic/op_server_asternic.cfg.

What do you think?

-- 
Alejandro Ríos Peña

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20060527/a723bc17/attachment.pgp