[Pkg-voip-commits] r3930 - in asterisk/trunk/debian: . patches

[Faidon Liambotis]

Tzafrir Cohen wrote:
> I'm not sure that the keys belong in /usr/share/asterisk - an
> administratormay wish to add some local keys for connecting various
> other Asterisk servers with RSA authentication.
> 
> This this dorectory is also used for local configuration. It should be
> in /var or /etc .
/var is not suitable for this, see the FHS.

I thought about this, /etc isn't that simple because the user may want
to delete the ones shipped by Debian.

The real solution would be to employ some kind of softlink mechanism,
like ca-certificates does.

Until then...

> So unless we come up with a system keys dir in /usr/share/asterisk/keys
> and a local keys dir in /var/lib/asterisk/key or /etc/asterisk/keys , I
> think we should revert to the way upstream works.
Actually, upstream uses /usr/share/asterisk/keys. The thing I changed
was a bugfix.

Have a look at the Makefile, it installs in ASTDATADIR/keys.
Also, asterisk.conf doesn't have a setting for changing the AST_KEY_DIR.
src/main/asterisk.c changes it, if ASTDATADIR is defined, to
ASTDATADIR/keys.

So, it's an upstream bug that I fixed.

Yes, I agree with you, as it is right now the user can't change the keys
and that's a bug.
The fix is non-trivial and until then we should follow upstream IMHO.

Faidon