freepbx 2.2.0 available on the svn

[Chris Halls]

Hi Diego

On Tuesday 16 January 2007 15:50, Diego Iastrubni wrote:
> I have been working hard on the last week to get a usable set of freepbx
> 2.2.0 packages. I am happy to tell you all it's now ready for testing.

Thanks for updating the packaging to 2.2.0. I am setting up a new freepbx 
installation and have had another look at the packaging. 

I have checked in a change to use the asterisk user for op-panel as in the 
latest package, because I was seeing this error:

Setting up freepbx-panel (2.2.0~dfsg-1) ...
chown: `op-panel.asterisk': invalid user

The mysql problems that I reported previously did not show up again. So maybe 
it was a problem because I was testing previously on a sarge machine, and on 
the new machine I am using etch/unstable.

So now onto some comments about the packaging. If you don't have much time 
don't worry about thinking about implementation now. It would help if you 
just say if you agree/disagree with them. If you're happy with my suggestions 
I can start making them myself.

- I think that freepbx-common would be a better name than freepbx-admin: 
Looking at the contents of the package, it is the place where all of the 
common parts are packaged and lots of other packages in Debian use 
the -common name for this.

- It's not really the debian way to have to say this in a package description:

Package: freepbx-apache-mysql
[...]
 Please install this package before installing freepbx-admin

Package: freepbx-apache2-mysql
[...]
 Please install this package before installing freepbx-admin.

etc.

It should be possible to apt-get install freepbx-admin, and let apt figure out 
which packages need to be installed and configured first. Do you know why 
these packages have these comments instead of the proper dependencies?

Here is my suggestion:

We pick a default freepbx recommended configuration, for example, apache2 + 
sqllite + php5. Then, we add a package for each optional way to configure 
freepbx:

Package: freepbx-mysql
Depends: freepbx-common, mysql-server | virtual-mysql-server,  php5-mysql | 
php4-mysql
Conflicts: freepbx-sqllite

Package: freepbx-sqllite
Depends: 
 freepbx-common, 
 sqlite3 | sqlite, 
 php5-sqlite3 | sqlite,
 sqlite3 | php4-sqlite, 
 freepbx-apache2 | php4-sqlite | freepbx-mathopd
Conflicts: freepbx-mysql

Package: freepbx-apache2
Depends: 
 freepbx-common, 
 apache2, 
 libapache2-mod-php5 | libapache2-mod-php4,
 php-pear | php4-pear,
Conflicts: freepbx-apache, freepbx-mathopd

Package: freepbx-apache
Depends: 
 freepbx-common, 
 apache, 
 libapache-mod-php4,
 php4-pear
Conflicts: freepbx-apache2, freepbx-mathopd

Package freepbx-common
Depends: 
 freepbx-apache2 | freepbx-apache | freepbx-mathopd, 
 freepbx-sqlite | freepbx-mysql
 libapache2-mod-php5 | freepbx-apache | freepbx-mathopd, sqlite3 | 
freepbx-mysql, php5-sqlite3 | php4-sqlite freepbx-mysql, php-pear

Package: freepbx-mathopd
Depends: 
 freepbx-common, 
 mathopd,
 php5-cgi | php4-cgi,
Conflicts: freepbx-apache, freepbx-apache2

So if you did 
 apt-get install freepbx-common
you would get freepbx + sqlite + apache2 + php5. You could change that by 
adding packages for the option you wanted, e.g. apt-get install freepbx-mysql 
freepbx-mathopd.

- The FAQ and README.Debian are in the freepbx meta package. Since I did not 
want to install ari, I did not install the metapackage and did not see those 
files. Maybe at least the README should go in freepbx-common? Also the 
ChangeLog is missing.

- How about adding a link /etc/freepbx.conf -> amportal.conf? It would make it 
easier for people looking for /etc/<packagename>.conf.

- I think /usr/share/freepbx-common/apply_conf.sh should be renamed 
to /usr/sbin/update-freepbx, just like other packages do.

- Not completely a freepbx packaging issue: When I tried a fresh out of the 
box install, asterisk wouldn't start because RUNASTERISK=no 
in /etc/default/asterisk. It wasn't obvious that this was a problem - 
XXXXXXXXX

- It wasn't obvious that the mysql default username + password is admin/admin. 
If you accept my suggestion above, we could add a README.mysql to the 
package. Or alternatively we could add a debconf interface to set this.

> Does anyone object me creating a directory freepbx/modules/2.2 and there
> uploading the modules? 

Sounds good to me.

Chris