freepbx 2.2.0 available on the svn

[Diego Iastrubni]

Hi Chris,

First of all, thanks for the attention. I would really like to hear about 
installations, and specially about bad experience: this is the best way I can 
learn. See comments inline.

On Thursday 01 February 2007 17:52, Chris Halls wrote:
> I have checked in a change to use the asterisk user for op-panel as in the
> latest package, because I was seeing this error:
>
> Setting up freepbx-panel (2.2.0~dfsg-1) ...
> chown: `op-panel.asterisk': invalid user
The op-panel package is still a mess. It's using code from our op-panel 
package which was been run as the user "op-panel". Thanks for fixing it.

> The mysql problems that I reported previously did not show up again. So
> maybe it was a problem because I was testing previously on a sarge machine,
> and on the new machine I am using etch/unstable.
see changeset 3104 :)

> - I think that freepbx-common would be a better name than freepbx-admin:
> Looking at the contents of the package, it is the place where all of the
> common parts are packaged and lots of other packages in Debian use
> the -common name for this.
or as you described in a later email: freepbx-core. Not sure, but I think core 
will sound better. The issue is that is contains much more then the core 
module, but I do not want to split the package even more. It's a mess 
already.

> - It's not really the debian way to have to say this in a package
> description:

> It should be possible to apt-get install freepbx-admin, and let apt figure
> out which packages need to be installed and configured first. Do you know
> why these packages have these comments instead of the proper dependencies?
by default it installs using apache2+mysql5+php5.
The reason behind this, is to enable users (me me me!) install different 
variations of this package. For example:

apt-get install asterisk # to overcome the problem you descrive bellow
nano /etc/default/asterisk
apt-get install freepbx-mathopd-sqlite3 asterisk-config-freepbx freepbx-admin 

> So if you did
>  apt-get install freepbx-common
> you would get freepbx + sqlite + apache2 + php5. You could change that by
> adding packages for the option you wanted, e.g. apt-get install
> freepbx-mysql freepbx-mathopd.
Now, if I understand what you say correctly, this means moving all my code of 
the freepbx-admin.postinst into the new packages post.inst. While it is a 
VERY GOOD solution, I am still afraid of code duplication: as all those 
packages will contain about 70% of the same code. 

Since the mess available in the postinst of those package is unacceptable, I 
will have to go your way in the future. To overcome the problem of "someone 
fixing freepbx-apache1-phpcgi5-mysql4 I will had commens to each of those 
files, in hope that he who commits will remember to commit in the other 
flavors.

> - The FAQ and README.Debian are in the freepbx meta package. Since I did
> not want to install ari, I did not install the metapackage and did not see
> those files. Maybe at least the README should go in freepbx-common? Also
> the ChangeLog is missing.
check. Thanks.

> - How about adding a link /etc/freepbx.conf -> amportal.conf? It would make
> it easier for people looking for /etc/<packagename>.conf.
This should be done upstream. I talked with Rob Thomas about this. This will 
be part of 2.3, and in the near future our packages as well (even in 2.2).

> - I think /usr/share/freepbx-common/apply_conf.sh should be renamed
> to /usr/sbin/update-freepbx, just like other packages do.
check. Thanks.

> - Not completely a freepbx packaging issue: When I tried a fresh out of the
> box install, asterisk wouldn't start because RUNASTERISK=no
> in /etc/default/asterisk. It wasn't obvious that this was a problem -
> XXXXXXXXX
See above. Tzafrir is trying to push the "asterisk should be enabled by 
default" patch for a year or so.

> - It wasn't obvious that the mysql default username + password is
> admin/admin. If you accept my suggestion above, we could add a README.mysql
> to the package. Or alternatively we could add a debconf interface to set
> this.
Also on sqlite*. It's an upstream decision (which took place arround 2.0 or 
2.1). 

> > Does anyone object me creating a directory freepbx/modules/2.2 and there
> > uploading the modules?
>
> Sounds good to me.
Next week. I still need to make the thing stable, and many of the modules are 
not working on sqlite3 for me (this is a must for our work here). 

I would like someone to test the pgsql support. As far as I can tell, "it 
should work", but since no one has ever tried it, I am not sure. This could 
be really cool support sqlite3/mysql/pgsql all in the same time.