MAKEFLAGS vs. OPTFLAGS

[Tzafrir Cohen]

Hi

A certain autobuild of asterisk failed for me. The failed line was:

dh_testdir
# Add here command to compile/build the package.
/usr/bin/make w -- 
make[2]: Entering directory
`/repo/debs/products/rapid/trunk/build-area/asterisk-svn/asterisk-1.2.14~dfsg'
make[2]: *** No rules to build target `w'.  Stop.


The lines from debian/rules:

MAKEFLAGS = OPTIMIZE=-O2 MAKECMDGOALS=dont-optimize
[snip]
build-arch-stamp: config.status
debian/build/asterisk-bristuff/config.status
	dh_testdir

	# Add here command to compile/build the package.
	$(MAKE) $(MAKEFLAGS)
	$(MAKE) $(MAKEFLAGS) -C channels/h323 opt
	$(MAKE) $(MAKEFLAGS) -C $(BRISTUFF_DIR)

It seems that someone is running 'make -w' and the option '-w'
propagates to MAKEFLAGS. See e.g. the following sample makefile:

cat <<EOF >test.mk
all:
	echo $(MAKE)
	echo $(MAKEFLAGS)
EOF
make -f test.mk -w --always-make
echo make
make
echo wB
wB


If you really want to use MAKEFLAGS, prepend a '-' before them. But I
gather we should go back to using MAKEOPTS. Or was this a bad name for
other reasons?

http://svn.debian.org/wsvn/pkg-voip/asterisk/trunk/debian/rules?op=diff&rev=1652&sc=1
http://svn.debian.org/wsvn/pkg-voip/asterisk/trunk/debian/?rev=1652&sc=1

-- 
               Tzafrir Cohen       
icq#16849755                    jabber:tzafrir at jabber.org
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com       
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir