Bug#433884: Should not depend on libopenH323, libpt, libSDL, libssl, libldap, ...

[Tzafrir Cohen]

On Fri, Jul 20, 2007 at 08:55:22AM +0300, Faidon Liambotis wrote:
> Turns out that H323LDFLAGS/H323LDLIBS are only included in main/Makefile 
> because of this.
> Second version of the patch that removes the craft.

> --- asterisk-1.4.8~dfsg.orig/main/Makefile
> +++ asterisk-1.4.8~dfsg/main/Makefile
> @@ -120,13 +120,6 @@ AST_EMBED_LDFLAGS:=$(foreach dep,$(EMBED
>  AST_EMBED_LIBS:=$(foreach dep,$(EMBED_LIBS),$(value $(dep)))
>  OBJS:=$(sort $(OBJS))
>  
> -ifneq ($(wildcard ../channels/h323/Makefile.ast),)
> -  include ../channels/h323/Makefile.ast
> -else
> -  H323LDFLAGS=
> -  H323LDLIBS=
> -endif
> -

Why wouldn't ../channels/h323/Makefile.ast be present? Elementary,
Watson: on the first run of make we generate it and then stop 'make'.
:-(

>  asterisk: $(OBJS) editline/libedit.a db1-ast/libdb1.a $(AST_EMBED_LDSCRIPTS)
>  	@$(ASTTOPDIR)/build_tools/make_build_h > $(ASTTOPDIR)/include/asterisk/build.h.tmp
>  	@if cmp -s $(ASTTOPDIR)/include/asterisk/build.h.tmp $(ASTTOPDIR)/include/asterisk/build.h ; then echo ; else \
> @@ -135,7 +128,7 @@ asterisk: $(OBJS) editline/libedit.a db1
>  	@rm -f $(ASTTOPDIR)/include/asterisk/build.h.tmp
>  	@$(CC) -c -o buildinfo.o $(ASTCFLAGS) buildinfo.c
>  	$(ECHO_PREFIX) echo "   [LD] $^ -> $@"
> -	$(CMD_PREFIX) $(CXX) $(STATIC_BUILD) -o $@ $(ASTLINK) $(AST_EMBED_LDFLAGS) $(ASTLDFLAGS) $(H323LDFLAGS) $^ buildinfo.o $(AST_LIBS) $(AST_EMBED_LIBS) $(H323LDLIBS)
> +	$(CMD_PREFIX) $(CC) $(STATIC_BUILD) -o $@ $(ASTLINK) $(AST_EMBED_LDFLAGS) $(ASTLDFLAGS) $^ buildinfo.o $(AST_LIBS) $(AST_EMBED_LIBS)
>  	@$(ASTTOPDIR)/build_tools/strip_nonapi $@
>  
>  clean::

I haven't tried it. But at first glance it seems as if this will breake
building chan_h323, right?

-- 
               Tzafrir Cohen       
icq#16849755                    jabber:tzafrir at jabber.org
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com       
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir