Bug#424984: openser: Insert Route HF (from Path) messes up

[Bernie Hoeneisen]

Hi Julien

I believe to have located the problem an wrote a patch (against the 
current debian stable) to circumvent it:

- The Route HF is inserted after the last Via HF,
   which means right before the From HF (in my case)

- If I also change the From HF, I run into the known limitation of
   OpenSER 'changing a HF twice gets unpredictable results' (lump stuff).

   It looks like that changing a HF and inserting a HF right before the
   changed one, ends up in same case as changing the HF twice.

- To circumvent the problem I rewrote the file
      openser/branches/1.1/modules/tm/path.c
   in such a way, that the Route HF is (if no Route HF present yet) always
   inserted right before the Call-ID HF, as the Call-ID MUST NOT be changed
   (unless you are a B2BUA).
   If there is no Call-ID HF, an error is returned.
   (This means I presume, that Call-ID must be present and not be changed)

Please find the patch in the attachment.
I have tested it on my system and it apprears to work fine.

cheers,
  Bernie



> Bernie Hoeneisen <bhoeneis at switch.ch> wrote:
>
> Hi,
>
>> Thus, it seems that calling the subst() function before the
>> (Path-info) Route HF is inserted causes the problem.
>
> Thanks for the testing, I'll watch for the bug upstream.
>
> I imagine you can't test openser 1.2 ?
>
> JB.
>
> -- 
> Julien BLACHE <jblache at debian.org>  |  Debian, because code matters more
> Debian & GNU/Linux Developer        |       <http://www.debian.org>
> Public key available on <http://www.jblache.org> - KeyID: F5D6 5169
> GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openser-1.1.0.debian.diff
Type: text/x-diff
Size: 2460 bytes
Desc: 
Url : http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20070519/bc9d5c7b/attachment.diff