Bug#426631: Should use libspeex instead of embedding a copy

Faidon Liambotis paravoid at debian.org
Wed May 30 06:57:58 UTC 2007


Package: libopenh323-1.18.0
Version: 1.18.0.dfsg-1+b1
Severity: important
Tags: patch

Below you will find a patch that corrects the check done by configure so
that speex_audio_pwplugin.so will use libspeex instead of embeding a
copy of the Speex library.
This will result in more bugfixes and can be quite important in an event
of a security vulnerability in the Speex algorithm.

The irony is that the source build-depends on libspeex-dev, even though
it isn't used _at all_ in the binaries.
I guess we agree on the result and this is a technical bug.

Please apply.

Best regards,
Faidon

--- openh323-1.18.0.dfsg.orig/plugins/configure	2006-10-22 15:25:38.000000000 +0300
+++ openh323-1.18.0.dfsg/plugins/configure	2007-05-30 09:40:37.000000000 +0300
@@ -3243,7 +3243,7 @@
       printf("%s\n", header.speex_version);
     }
 C_FILE
-    cc -o t t.c -lspeex > /dev/null 2>&1
+    cc -o t t.c -I/usr/include/speex -lspeex > /dev/null 2>&1
     if test \! -x t ; then
       echo "$as_me:$LINENO: result: cannot determine - using library version" >&5
 echo "${ECHO_T}cannot determine - using library version" >&6
--- openh323-1.18.0.dfsg.orig/plugins/configure.ac	2006-10-22 15:25:38.000000000 +0300
+++ openh323-1.18.0.dfsg/plugins/configure.ac	2007-05-30 09:38:51.000000000 +0300
@@ -117,7 +117,7 @@
       printf("%s\n", header.speex_version);
     }
 C_FILE
-    cc -o t t.c -lspeex > /dev/null 2>&1
+    cc -o t t.c -I/usr/include/speex -lspeex > /dev/null 2>&1
     if test \! -x t ; then
       AC_MSG_RESULT(cannot determine - using library version)
     else




More information about the Pkg-voip-maintainers mailing list