Bug#473704: ser: bashism in /bin/sh script

[Raphael Geissert]

Package: ser
Severity: important
Version: 0.9.7-1
User: debian-release at lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing several /bin/sh scripts making 
use of a bashism.

checkbashisms' output:
> possible bashism in ./usr/sbin/ser_mysql.sh line 173 ($RANDOM):
>   PHPLIB_ID=`$GENHA1 "$RANDOM" "$NOW" $SIP_DOMAIN`
> possible bashism in ./usr/sbin/serctl line 565 (should be 'b = a'):
>                         if [ "$MODE" == "add" ] ; then
> possible bashism in ./usr/sbin/serctl line 917 (should be 'b = a'):
>                 if [ "$2" == "" ]; then
> possible bashism in ./etc/init.d/ser line 74 (echo -e):
>             echo -e "\nThere are errors in the configuration file. Please
> fix them first" possible bashism in ./etc/init.d/ser line 75 (echo -e):
>             echo -e "\n$out\n"

Not using bash (or a Debian Policy conformant shell interpreter which doesn't 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html