[Pkg-voip-commits] r4154 - asterisk-prompt-fr-proformatique/trunk/debian

[Lionel Elie Mamane]

On Sun, Aug 19, 2007 at 11:30:53PM +0000, tzafrir-guest at alioth.debian.org wrote:
> Author: tzafrir-guest
> Date: 2007-08-19 23:30:53 +0000 (Sun, 19 Aug 2007)
> New Revision: 4154

> Log:
> * Fix file locations.

> Added: asterisk-prompt-fr-proformatique/trunk/debian/install
> ===================================================================
> --- asterisk-prompt-fr-proformatique/trunk/debian/install	                        (rev 0)
> +++ asterisk-prompt-fr-proformatique/trunk/debian/install	2007-08-19 23:30:53 UTC (rev 4154)
> @@ -0,0 +1,5 @@
> +fr          usr/share/asterisk/sounds
> +dictate     usr/share/asterisk/sounds
> +digits      usr/share/asterisk/sounds
> +letters     usr/share/asterisk/sounds
> +phonetic    usr/share/asterisk/sounds

> Modified: asterisk-prompt-fr-proformatique/trunk/debian/rules
> ===================================================================
> --- asterisk-prompt-fr-proformatique/trunk/debian/rules	2007-08-19 22:26:20 UTC (rev 4153)
> +++ asterisk-prompt-fr-proformatique/trunk/debian/rules	2007-08-19 23:30:53 UTC (rev 4154)
> @@ -25,7 +25,7 @@
>  clean:
>  	dh_testdir
>  	dh_testroot
> -	rm -f build-stamp debian/links
> +	rm -f build-stamp
>  
>  	dh_clean
>  
> @@ -34,19 +34,9 @@
>  	dh_testroot
>  	dh_clean -k
>  	dh_installdirs
> +	dh_install
>  	dh_installchangelogs
>  	dh_installdocs
> -
> -	set -e; find . -mindepth 1 -maxdepth 1 -not -name debian $(NO_DISTRIB_FIND_EXPR) -print0 | xargs --null cp -R -tdebian/$(PKG_NAME)/usr/share/asterisk/sounds/$(LNG)/
> -
> -	set -e; \
> -	( cd debian/$(PKG_NAME)/usr/share/asterisk/sounds/$(LNG)/; \
> -	  for d in $$(find . -mindepth 1 -maxdepth 1 -type d -printf '%P\n'); do \
> -	    mkdir -p ../$${d}; \
> -	    [ "$(LNG)" = "$${d}" ]||echo usr/share/asterisk/sounds/$(LNG)/$${d} usr/share/asterisk/sounds/$${d}/$(LNG); \
> -	  done ) > debian/links
> -	dh_link
> -
>  	dh_compress
>  	dh_installdeb
>  	dh_gencontrol


There are several wrong things with this commit:

 - It seems to me this breaks compatibility with an Asterisk
   configured with "languageprefix=yes".

 - It tries to replace symlinks with true directories, something that
   dpkg will not do automatically; achieving that requires doing it
   manually in preinst. See Debian policy §6.6, end of item number
   4 in the itemised list:

          A directory will never be replaced by a symbolic link to a
          directory or vice versa; instead, the existing state (symlink or
          not) will be left alone and `dpkg' will follow the symlink if
          there is one.

   (That's why it didn't break my existing installations and I missed
   the problem when I tested the new package.)


Any opposition on me reverting that change?


(Please CC me on replies / followups; thanks.)

-- 
Lionel