Bug#530047: asterisk: bashism in /bin/sh script

[Tzafrir Cohen]

On Sat, May 23, 2009 at 12:07:40AM -0500, Raphael Geissert wrote:

> checkbashisms' output:
> > possible bashism in ./usr/sbin/safe_asterisk line 52 ($(OS|MACH)TYPE):
> >	  if `echo $OSTYPE | grep linux 2>&1 > /dev/null `
> > possible bashism in ./usr/sbin/safe_asterisk line 65 ($(OS|MACH)TYPE):
> >	  elif `echo $OSTYPE | grep darwin 2>&1 > /dev/null `
> > possible bashism in ./usr/sbin/safe_asterisk line 124 (should be '.', not
> > 'source'):
> >			  source ${script}

Simple to fix.

> > possible bashism in ./usr/sbin/safe_asterisk line 136 (should be >word
> > 2>&1):
> >			  nice -n $PRIORITY ${ASTSBINDIR}/asterisk -f
> > ${CLIARGS} ${ASTARGS} >& /dev/${TTY} < /dev/${TTY}

Already fixed upstream. Not present in 1.6.1 which should hit Lenny
soon.

> > possible bashism in ./usr/sbin/safe_asterisk line 148 (let ...):
> >			  let EXITSIGNAL=EXITSTATUS-128

Likewise, simple ot fix.

Something new I get in 1.6.1 (and also in upstream trunk)

  possible bashism in - line 92 (ulimit):
          ulimit -n $MAXFILES
  possible bashism in - line 103 (ulimit):
  ulimit -c unlimited

I can't think of a simple workaround. OTOH, dash seems to be fine with
that (posh isn't , busybox ash in Lenny also seems to be fine with it).
Worth fixing? How?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir