Bug#530047: asterisk: bashism in /bin/sh script

[Tzafrir Cohen]

On Mon, May 25, 2009 at 08:35:18PM +0930, Ron wrote:
> On Sun, May 24, 2009 at 03:16:43PM -0500, Raphael Geissert wrote:
> > On Saturday 23 May 2009 10:33:58 Tzafrir Cohen wrote:

> > So, you have two options: leave it the way it is, or catch the error produced 
> > when ulimit is not implemented.
> 
> Uhm, _three_ options: declare the script(s) explicitly require /bin/bash

But it's not. Most of the bashism has been eliminated. The one remaining
point is one that does not comply with policy, but does not harm the
dash target either.

> 
> The 'safe_asterisk' script is already a horrible kludge to work around a
> buggy app.  Applying further layers of horrible kludges to that, just to
> avoid using the language that it apparently needs to do some of its heavy
> kludging, doesn't really seem like a Good Idea, does it?

The bashisms there were mostly ignorant programming, actually. Such as
using 'let' and 'source'.

Can you point to some places that checkbashism has missed?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir