Bug#582095: dahdi-linux: Adding support for Aligera cards

[Tzafrir Cohen]

On Tue, May 18, 2010 at 11:37:09AM +0200, François wrote:
> Package: dahdi-linux
> Version: 2:2.2.1+dfsg-1.cm.100518
> Severity: wishlist
> 
> 
> It would be nice to support PRI cards from Aligera.
> 
> Attached are modified patches based on the ones found in there website
> that work well for me. We are in contact with Aligera and those
> modifications should be included in the next revision of their drivers.

What sort of contact?

Have those drivers been posted for inclusion in DAHDI?

Lacking that, we need to have someone who can answer questions for them.
If I need to fix something, I need to have someone who can say that the
fix won't break anything. Not to mention someone who can actually test
the new version. Can you do that?

I tried building those drivers vs. current dahdi trunk.

sparse (building with 'make C=1'. You need the package 'sparse' from
non-free) gives the following:

drivers/dahdi/ap400/ap400_drv.c:2309:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:2310:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:2314:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:2316:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:2317:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:2318:2: warning: obsolete struct initializer, use C99 syntax
drivers/dahdi/ap400/ap400_drv.c:691:31: warning: incorrect type in argument 2 (different address spaces)
drivers/dahdi/ap400/ap400_drv.c:691:31:   expected void const [noderef] <asn:1>*from
drivers/dahdi/ap400/ap400_drv.c:691:31:   got int *<noident>
drivers/dahdi/ap400/ap400_drv.c:730:22: warning: incorrect type in argument 1 (different address spaces)
drivers/dahdi/ap400/ap400_drv.c:730:22:   expected void [noderef] <asn:1>*to
drivers/dahdi/ap400/ap400_drv.c:730:22:   got int *<noident>
drivers/dahdi/ap400/ap400_drv.c:735:31: warning: incorrect type in argument 2 (different address spaces)
drivers/dahdi/ap400/ap400_drv.c:735:31:   expected void const [noderef] <asn:1>*from
drivers/dahdi/ap400/ap400_drv.c:735:31:   got int *<noident>
drivers/dahdi/ap400/ap400_drv.c:742:22: warning: incorrect type in argument 1 (different address spaces)
drivers/dahdi/ap400/ap400_drv.c:742:22:   expected void [noderef] <asn:1>*to
drivers/dahdi/ap400/ap400_drv.c:742:22:   got int *<noident>
drivers/dahdi/ap400/ap400_drv.c:1804:23: error: no member 'bpvcount' in struct dahdi_span
drivers/dahdi/ap400/ap400_drv.c:1807:23: error: no member 'crc4count' in struct dahdi_span

And the last two lines are also errors by the compiler:
drivers/dahdi/ap400/ap400_drv.c: In function ‘init_spans’:
drivers/dahdi/ap400/ap400_drv.c:1025: warning: unused variable ‘c’
drivers/dahdi/ap400/ap400_drv.c: In function ‘ap4_interrupt’:
drivers/dahdi/ap400/ap400_drv.c:1804: error: ‘struct dahdi_span’ has no member named ‘bpvcount’
drivers/dahdi/ap400/ap400_drv.c:1807: error: ‘struct dahdi_span’ has no member named ‘crc4count’

And indeed:
svn_2.2:drivers/dahdi/dahdi-base.c: stack.spaninfo.bpvcount = spans[i]->bpvcount;
svn_2.3:drivers/dahdi/dahdi-base.c: stack.spaninfo.bpvcount = spans[i]->count.bpv;
http://svnview.digium.com/svn/dahdi?view=revision&revision=8061

I'm hoping to upload 2.3 soon.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir