Bug#658504: siproxd: issues with debian packaging (conf and init)

[Alban Browaeys]

Package: siproxd
Version: 1:0.8.1-2
Severity: normal

Dear Maintainer,
The init fails to stop and restart siproxd due to the PIDFILE path missing the directory
name:
origin: PIDFILE=/var/run/$NAME.pid
fixed: PIDFILE=/var/run/$NAME/$NAME.pid
Otherwise the pid file cannot be created in /var/run with siproxd user (or nobody user).
Only in /var/run/siproxd/ it could.
This fixes the stop and restart from init scripts.

In the default conf /etc/siproxd.conf there is a mismatch with the init script. The later starts
 siproxd as user siproxd but the default conf ship with user nobody used.

Last the .la removal has brokne the default config for plugins . Ie they are called with .la
 while .la are removed. Disregarding the commentin the config file I changed the suffix to .so in
 the conf and it seems to work (and avoiding filling the error log with plugin*.la not found). 

All looks fine after those changes.

Best regards
Alban


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.3.0-rc2+ (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages siproxd depends on:
ii  adduser     3.113+nmu1
ii  libc6       2.13-25
ii  libltdl7    2.4.2-1
ii  libosip2-4  3.3.0-1

siproxd recommends no packages.

siproxd suggests no packages.

-- Configuration Files:
/etc/default/siproxd changed:
ENABLED=1

/etc/init.d/siproxd changed:
set -e
PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
DAEMON=/usr/sbin/siproxd
NAME=siproxd
DESC="SIP proxy"
ENABLED=0
PIDFILE=/var/run/$NAME/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
test -x $DAEMON || exit 0
test -d /var/run/$NAME || install -d -o siproxd -g siproxd /var/run/$NAME
if [ -r /etc/default/$NAME ]
then
	. /etc/default/$NAME
fi
if [ "$ENABLED" = "0" ]
then
    echo "To enable siproxd, the sip proxy, modify /etc/default/siproxd"
    exit 0
fi
start()
{
    echo -n "Starting $DESC: $NAME"
    start-stop-daemon --start --quiet --pidfile $PIDFILE \
	 --exec $DAEMON -- -p $PIDFILE
    echo "."
}
stop()
{
	echo -n "Stopping $DESC: $NAME"
	if test -e $PIDFILE; then
	    start-stop-daemon --stop --quiet --pidfile $PIDFILE
	fi
	echo "."
	rm -f $PIDFILE
}    
case "$1" in
  start)
	start
	;;
  stop)
	stop
	;;
  restart|force-reload)
	stop
	start
	;;
  *)
	echo "Usage: $SCRIPTNAME {start|stop|restart|force-reload}" >&2
	exit 1
	;;
esac
exit 0

/etc/siproxd.conf changed:
if_inbound  = maison0
if_outbound = external0
sip_listen_port = 5060
daemonize = 1
silence_log = 1
user = siproxd
registration_file = /var/lib/siproxd/siproxd_registrations
autosave_registrations = 300
pid_file = /var/run/siproxd/siproxd.pid
rtp_proxy_enable = 1
rtp_port_low  = 7070
rtp_port_high = 7089
rtp_timeout = 300
rtp_dscp = 46
sip_dscp = 0
rtp_input_dejitter  = 0
rtp_output_dejitter = 0
tcp_timeout = 600
tcp_connect_timeout = 500
tcp_keepalive = 20
debug_level =      0x00000000
debug_port = 0
plugindir=/usr/lib/siproxd/
load_plugin=plugin_logcall.so
plugin_demo_string = This_is_a_string_passed_to_the_demo_plugin
plugin_shortdial_akey = *00
plugin_shortdial_entry = 17474743246
plugin_shortdial_entry = 17474745000
plugin_defaulttarget_log = 1
plugin_defaulttarget_target = sip:internal at dddd:port
plugin_fix_bogus_via_networks = 10.0.0.0/8,172.16.0.0/12,192.168.0.0/16
plugin_stun_server = stun.xten.com
plugin_stun_port = 3478
plugin_stun_period = 300
plugin_prefix_akey = 0
plugin_regex_desc    = Test Regex 1
plugin_regex_pattern = ^sip:00
plugin_regex_replace = +
plugin_regex_desc    = Test Regex 2
plugin_regex_pattern = ^sip:01
plugin_regex_replace = +a
plugin_regex_desc    = Test Regex 3
plugin_regex_pattern = ^(sips?):01
plugin_regex_replace = \1:001


-- no debconf information