Bug#705921: asterisk: debian/rules using ` instead of $(shell

[Jeremy Lainé]

Package: asterisk
Version: 1:1.8.13.1~dfsg-3
Severity: normal

The debian/rules file is using backticks to set CFLAGS and LDFLAGS
instead of $(shell ..) which is incorrect, as it is not garanteed
to be expanded:

CFLAGS = `dpkg-buildflags --get CFLAGS`
LDFLAGS = `dpkg-buildflags --get LDFLAGS`
CFLAGS += `dpkg-buildflags --get CPPFLAGS`

This currently has no visible effect to my knowledge, but it will cause
trouble when packaging asterisk 11, the build fails with:

dpkg-buildflags: No such file or directory

The same issue was found and fixed in rsync in #699165.

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages asterisk depends on:
ii  adduser                                           3.113+nmu3
pn  asterisk-config | asterisk-config-custom          <none>
pn  asterisk-core-sounds-en-gsm | asterisk-prompt-en  <none>
pn  asterisk-modules                                  <none>
ii  libc6                                             2.13-37
ii  libcap2                                           1:2.22-1.2
ii  libgcc1                                           1:4.7.2-5
ii  libssl1.0.0                                       1.0.1e-1
ii  libstdc++6                                        4.7.2-5
ii  libtinfo5                                         5.9-10
ii  libxml2                                           2.8.0+dfsg1-7+nmu1

Versions of packages asterisk recommends:
pn  asterisk-moh-opsound-gsm                         <none>
pn  asterisk-voicemail | asterisk-voicemail-storage  <none>
ii  sox                                              14.4.0-3

Versions of packages asterisk suggests:
pn  asterisk-dahdi   <none>
pn  asterisk-dev     <none>
pn  asterisk-doc     <none>
pn  asterisk-ooh323  <none>