[Bug 1212743] Re: mumble crashes on multi-speaker setups

[Marc Deslauriers]

Thanks for submitting this debdiff.

This part doesn't look quite right:

+@@ -295,12 +296,13 @@ void PulseAudioSystem::eventCallback(pa_
+ 							pa_stream_unref(pasSpeaker);
+ 
+ 						pa_sample_spec pss = qhSpecMap.value(edev);
++						pa_channel_map pcm = qhChanMap.value(edev);
+ 						if (pss.rate == 0)
+ 							pss.rate = SAMPLE_RATE;
+ 						pss.channels = 1;
+ 						if ((pss.format != PA_SAMPLE_FLOAT32NE) && (pss.format != PA_SAMPLE_S16NE))
+ 							pss.format = PA_SAMPLE_FLOAT32NE;
+-						pasSpeaker = pa_stream_new(pacContext, "Mumble Speakers (Echo)", &pss, NULL);
++						pasSpeaker = pa_stream_new(pacContext, "Mumble Speakers (Echo)", &pss, (pss.channels == 1) ? NULL : &pcm);
+ 						pa_stream_set_state_callback(pasSpeaker, stream_callback, this);
+ 						pa_stream_set_read_callback(pasSpeaker, read_callback, this);
+ 					}


if pss.channels is forced to 1, why add the test later on?
Either that whole change isn't needed, or you need some more of the changes from the original commit:

https://github.com/mumble-
voip/mumble/commit/c245e2d1678c3f7b15e96382f36075b9a92ec031

Could you please clarify, modify the debdiff, and test?

Thanks!

-- 
You received this bug notification because you are a member of Debian
VoIP Team, which is subscribed to mumble in Ubuntu.
https://bugs.launchpad.net/bugs/1212743

Title:
  mumble crashes on multi-speaker setups

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mumble/+bug/1212743/+subscriptions