Bug#702753: spandsp: Downloads external files at build time (through xsltproc) -- missing Build-Depends?

[Daniel Schepler]

Source: spandsp
Version: 0.0.6~pre20-3
Severity: serious

When I recently did a full build of spandsp in pbuilder, it happened
that my net connection went down momentarily, and I noticed this in
the build log:

...
cd t38_manual ; xsltproc ../wrapper.xsl ../t38_manual.xml
error : connection refused
../t38_manual.xml:3: warning: failed to load external entity
"http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd"
               "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">
                                                                        ^
Writing ch01.html for chapter(what-is-t38)
Writing ch02.html for chapter(the-basics-of-a-t38-entity)
Writing ch03s02.html for sect1
Writing ch03.html for chapter(the-core-elements-of-a-t38-implementation)
Writing ch04.html for chapter(the-elements-of-a-t38-terminal)
Writing ch05s02.html for sect1
Writing ch05s03.html for sect1
Writing ch05s04.html for sect1
Writing ch05.html for chapter(the-elements-of-a-t38-gateway)
Writing ch06.html for chapter(testing-an-implementation-of-t38)
Writing ch07s02.html for sect1
Writing ch07s03.html for sect1
Writing ch07s04.html for sect1
Writing ch07s05.html for sect1
Writing ch07s06.html for sect1
Writing ch07.html for chapter(living-with-real-world-t38-entities)
Writing index.html for book
make[3]: Leaving directory `/tmp/buildd/spandsp-0.0.6~pre20/doc'
Making all in test-data
make[3]: Entering directory `/tmp/buildd/spandsp-0.0.6~pre20/test-data'
...

Though the package continued building and the build completed
successfully, downloading external files during the build process is a
serious issue (as it violates the reasonable expectation that source
packages shouldn't act as spyware when you build them).  Not to
mention that if the docs come out differently depending on whether the
build machine has net access or not, that's another serious issue -- I
didn't check whether this was the case or not for this package.

If I add docbook-xml and docbook to the Build-Depends, that seems to
resolve this issue, if I do a test rebuild with the network connection
temporarily disabled.  I'm not sure if both of those are needed...
-- 
Daniel Schepler