Bug#726410: spandsp: FTBFS in parallel mode

[Andreas Moog]

Hi Gregor, hi Daniel,

the same build failure happened in Ubuntu on i386 and amd64, the 2
"fastest" building architectures in Ubuntu. This leads me to believe
this is a race condition and, while full local builds always succeeded,
here is a way to reproduce:

After doing a full build, cd into
spandsp-0.0.6~pre21/test-data/itu/fax

and execute:

while true; do make clean; make -j8 || break; done

This will continuously try to clean and rebuild the files in that
directory, leading after a short while into the above mentioned errors.

As for the reason I believe this happens: You can see in the build-log
that the ./generate_sized_pages script is executed multiple times, once
for each parallel instance, leading to the race condition. I've attached
a simple fix to disable parallel execution of the image generating
scripts, which I believe is the most simple solution - but I'm not an
expert on autotools.

Cheers,
  Andreas


-- 
Andreas Moog, Berliner Str. 29, 36205 Sontra/Germany
Ubuntu Developer
PGP-encrypted mails preferred (Key-ID: 74DE6624)
PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624
-------------- next part --------------
diff -Nru spandsp-0.0.6~pre21/debian/changelog spandsp-0.0.6~pre21/debian/changelog
--- spandsp-0.0.6~pre21/debian/changelog	2013-08-04 02:05:45.000000000 +0200
+++ spandsp-0.0.6~pre21/debian/changelog	2013-11-28 00:39:47.000000000 +0100
@@ -1,3 +1,11 @@
+spandsp (0.0.6~pre21-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Fix FTBFS in parallel mode by disabling multiple execution of
+    the scripts that generate images. (Closes: #726410)
+
+ -- Andreas Moog <amoog at ubuntu.com>  Thu, 28 Nov 2013 00:39:08 +0100
+
 spandsp (0.0.6~pre21-1) unstable; urgency=low
 
   * New upstream release
diff -Nru spandsp-0.0.6~pre21/debian/patches/fix-ftbfs-parallel.patch spandsp-0.0.6~pre21/debian/patches/fix-ftbfs-parallel.patch
--- spandsp-0.0.6~pre21/debian/patches/fix-ftbfs-parallel.patch	1970-01-01 01:00:00.000000000 +0100
+++ spandsp-0.0.6~pre21/debian/patches/fix-ftbfs-parallel.patch	2013-11-28 00:38:56.000000000 +0100
@@ -0,0 +1,14 @@
+Description: Don't execute multiple instances of the scripts generating
+ the images. It can lead to a race condition while building in parallel
+ mode.
+Author: Andreas Moog <andreas.moog at warperbbs.de>
+Bug-Debian: http://bugs.debian.org/726410
+
+--- spandsp-0.0.6~pre21.orig/test-data/itu/fax/Makefile.am
++++ spandsp-0.0.6~pre21/test-data/itu/fax/Makefile.am
+@@ -153,3 +153,5 @@ mixed_size_pages.tif: ${MIXED_SIZE_PAGES
+ 
+ striped.tif: generate_striped_pages$(EXEEXT)
+ 	./generate_striped_pages$(EXEEXT)
++
++.NOTPARALLEL: dithered.tif mixed_size_pages.tif striped.tif
diff -Nru spandsp-0.0.6~pre21/debian/patches/series spandsp-0.0.6~pre21/debian/patches/series
--- spandsp-0.0.6~pre21/debian/patches/series	2013-08-04 02:05:45.000000000 +0200
+++ spandsp-0.0.6~pre21/debian/patches/series	2013-11-28 00:37:51.000000000 +0100
@@ -1,3 +1,4 @@
 serial-tests
 array_warning
 fix-ftbfs-on-powerpcspe.patch
+fix-ftbfs-parallel.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20131128/7a8aa534/attachment.sig>