Bug#720824: opal: FTBFS with libav9: h263-1998.cxx:320:27: error: 'CODEC_FLAG_H263P_UMV' was not declared in this scope

[Sebastian Ramacher]

Control: tags -1 + patch

On 2013-09-12 15:36:20, Eugen Dedu wrote:
> On 12/09/13 15:29, Sebastian Ramacher wrote:
> >On 2013-09-06 16:16:59, Eugen Dedu wrote:
> >>On 06/09/13 15:34, Moritz Muehlenhoff wrote:
> >>>On Sun, Aug 25, 2013 at 03:22:31PM +0200, David Suárez wrote:
> >>>>Source: opal
> >>>>Version: 3.10.10~dfsg-2
> >>>>Severity: serious
> >>>>Tags: jessie sid
> >>>>User: debian-qa at lists.debian.org
> >>>>Usertags: qa-ftbfs-20130825 qa-ftbfs
> >>>>Justification: FTBFS on amd64
> >>>>
> >>>>Hi,
> >>>>
> >>>>During a rebuild of all packages in sid, your package failed to build on
> >>>>amd64.
> >>>>
> >>>>Related to current libav9 transition (see #706798).
> >>>>
> >>>>>                                                                         ^
> >>>>>h263-1998.cxx: In member function 'virtual bool H263_RFC2190_EncoderContext::Init()':
> >>>>>h263-1998.cxx:606:24: error: 'CODEC_FLAG_H263P_UMV' was not declared in this scope
> >>>>>    m_context->flags &= ~CODEC_FLAG_H263P_UMV;
> >>>>>                         ^
> >>>>>h263-1998.cxx:611:24: error: 'CODEC_FLAG_H263P_AIV' was not declared in this scope
> >>>>>    m_context->flags &= ~CODEC_FLAG_H263P_AIV;
> >>>>>                         ^
> >>>>>h263-1998.cxx:612:24: error: 'CODEC_FLAG_H263P_SLICE_STRUCT' was not declared in this scope
> >>>>>    m_context->flags &= ~CODEC_FLAG_H263P_SLICE_STRUCT;
> >>>>>                         ^
> >>>>>make[5]: *** [/«PKGBUILDDIR»/plugins/../lib_linux_x86_64/plugins/h263_ffmpeg/h263-1998.o] Error 1
> >>>
> >>>This is fixed in the version from experimental (ptlib from experimental is also needed),
> >>>which compiles fine against current libav.
> >>
> >>Thank you for this information.
> >>
> >>Note that ekiga does not yet work with opal/experimental, so opal
> >>cannot go to unstable right now.
> >
> >Would it be possible to backport the libav 9 fixes for now? I found some
> >patches on the web that make it compile, but they don't fix
> >plugins/video/common/dyna.cxx which uses dlopen/dlsym to look up the
> >(old) libav symbols (thankfully this is properly fixed in experimental).
> > From what I can tell it might be enough to just replace the loading and
> >calls to Fav* in FFMPEGLibrary with plain calls of av* functions.
> 
> It is on my TODO list, but I am in short time currently...  Please
> give me all the pointers you have.  My plan is to backport the
> related changes from experimental version to unstable/testing
> version.

I gave it a try and ended up with the attached patch. What do you think
of it?

Regards
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libav9-opal.diff
Type: text/x-diff
Size: 20295 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20130912/fdd33436/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20130912/fdd33436/attachment-0001.sig>