Bug#777829: dahdi-tools: ftbfs with GCC-5

[Matthias Klose]

Package: src:dahdi-tools
Version: 1:2.10.0.1-1
Severity: normal
Tags: sid stretch
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-5

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-5/g++-5, but succeeds to build with gcc-4.9/g++-4.9. The
severity of this report may be raised before the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc5-20150205/dahdi-tools_2.10.0.1-1_unstable_gcc5.log
The last lines of the build log are at the end of this report.

To build with GCC 5, either set CC=gcc-5 CXX=g++-5 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ 

Common build failures are C11 as the default C mode, new warnings
resulting in build failures with -Werror turned on, or new/dropped
symbols in Debian symbols files.  For other C/C++ related build failures
see the porting guide at http://gcc.gnu.org/gcc-5/porting_to.html

[...]
ranlib libtonezone.a
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT fxotune.o -MF .fxotune.o.d -MP -c -o fxotune.o fxotune.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro fxotune.o version.o -lm -o fxotune
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT dahdi_cfg.o -MF .dahdi_cfg.o.d -MP -c -o dahdi_cfg.o dahdi_cfg.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro dahdi_cfg.o version.o libtonezone.a -lm -lpthread -o dahdi_cfg
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT dahdi_monitor.o -MF .dahdi_monitor.o.d -MP -c -o dahdi_monitor.o dahdi_monitor.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro dahdi_monitor.o version.o  -o dahdi_monitor
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT dahdi_test.o -MF .dahdi_test.o.d -MP -c -o dahdi_test.o dahdi_test.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro dahdi_test.o version.o  -o dahdi_test
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT dahdi_scan.o -MF .dahdi_scan.o.d -MP -c -o dahdi_scan.o dahdi_scan.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro dahdi_scan.o version.o  -o dahdi_scan
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT dahdi_maint.o -MF .dahdi_maint.o.d -MP -c -o dahdi_maint.o dahdi_maint.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro dahdi_maint.o version.o  -o dahdi_maint
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE    -MD -MT dahdi_tool.o -MF .dahdi_tool.o.d -MP -c -o dahdi_tool.o dahdi_tool.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE    -Wl,-z,relro dahdi_tool.o version.o -lnewt  -o dahdi_tool
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -MD -MT sethdlc.o -MF .sethdlc.o.d -MP -c -o sethdlc.o sethdlc.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -O2 -g -fPIC -Wall -DBUILDING_TONEZONE   -Wl,-z,relro sethdlc.o version.o  -o sethdlc
make[3]: Entering directory '/«PKGBUILDDIR»/xpp'
Makefile:201: .depend: No such file or directory
Calculating dependencies
gcc -MM -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api \
	`oct612x/octasic-helper objects | \
	tr -s ' ' '\n' | \
	sed -e 's,.*,oct612x/&,' -e 's/\.o$/.c/'` > .octasic.depend
for i in dahdi_registration xpp_sync lsdahdi xpp_blink dahdi_genconf dahdi_hardware twinstar; do perl -I./perl_modules -c $i || exit 1; done
dahdi_registration syntax OK
xpp_sync syntax OK
lsdahdi syntax OK
xpp_blink syntax OK
dahdi_genconf syntax OK
dahdi_hardware syntax OK
twinstar syntax OK
touch .perlcheck
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -Ixtalk -Wall -Werror -D_FORTIFY_SOURCE=2  -c -o astribank_is_starting.o astribank_is_starting.c
gcc -Wl,-z,relro astribank_is_starting.o  -o astribank_is_starting
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -Ixtalk -Wall -Werror -D_FORTIFY_SOURCE=2  -c -o astribank_tool.o astribank_tool.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -Ixtalk -Wall -Werror -D_FORTIFY_SOURCE=2  -c -o astribank_usb.o astribank_usb.c
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I. -Ixtalk -Wall -Werror -D_FORTIFY_SOURCE=2  -c -o mpptalk.o mpptalk.c
mpptalk.c: In function 'mpp_send_seg':
mpptalk.c:515:28: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
  if(!astribank->burn_state == BURN_STATE_STARTED) {
                            ^
cc1: all warnings being treated as errors
make[3]: *** [mpptalk.o] Error 1
<builtin>: recipe for target 'mpptalk.o' failed
make[3]: Leaving directory '/«PKGBUILDDIR»/xpp'
make[2]: *** [utils-subdirs] Error 2
make[1]: *** [override_dh_auto_build] Error 2
make: *** [build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2