Bug#779292: dahdi init script hides dahdi_cfg stderr and don't check dahdi_cfg exit status

[bertrand]

Package: dahdi
Version: 1:2.5.0.1-2
Severity: normal

Dear Maintainer,


  * What led up to the situation?

Fresh install of dahdi/asterisk, which ends up with a mistake in
/etc/dahdi/system.conf (in my case due to improper line "lc_country ca"
from genconf_parameter propagated to system.conf by dahdi_genconf)


  * What was the outcome of this action?

Since /etc/dahdi/system.conf contains an error, dahdi_cfg will fail.
However, dahdi init script redirect dahdi_cfg stderr to /dev/null and
don't check dahdi_cfg exit code:

	if [ $system = debian ]; then
		echo -n "Running dahdi_cfg: "
		$DAHDI_CFG_CMD 2> /dev/null && echo -n "done"
		echo "."

Your only chance to notice something was wrong is the missing "done" 
after "Running dahdi_cfg: ".

Dahdi seems to start as expected, leaving your span as UNCONFIGURED,
which is quite misleading.


  * What outcome did you expect instead?

I'm expecting dahdi init script to be more explicit and display potential
dahdi_cfg error. It could even check dahdi_cfg exit code and act
accordingly.



-- System Information:
Debian Release: 7.8
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages dahdi depends on:
ii  dahdi-linux     1:2.6.1+dfsg2-1
ii  fxload          0.0.20081013-1
ii  libc6           2.13-38+deb7u8
ii  libnewt0.52     0.52.14-11.1
ii  libtonezone2.0  1:2.5.0.1-2
ii  libusb-0.1-4    2:0.1.12-20+nmu1
ii  perl            5.14.2-21+deb7u2
ii  procps          1:3.3.3-3

dahdi recommends no packages.

dahdi suggests no packages.

-- no debconf information