Bug#802634: asterisk: should link against Corosync

[Jonas Smedegaard]

Quoting Tzafrir Cohen (2015-11-08 05:10:55)
> On Thu, Oct 22, 2015 at 12:45:49AM +0200, Jonas Smedegaard wrote:
>> Asterisk supports linkage against Corosync, but that seems 
>> deliberately avoided in the Debian packaging.
>> 
>> I wonder why it was avoided - changelog entry for 1:13.0.0~dfsg-3 
>> says "Remove corosync support: doesn't work" but doesn't really 
>> explain what didn't work.
>>
>> If it was bug#771432 then that bug seems to only suggest disabling 
>> the module by default, not avoiding building the module altogether 
>> (might work fine when properly configured).  Also, if it is that 
>> issue, then that bugreport should probably be closed, referencing 
>> that release.
>>
>> Perhaps the seemingly major cleanup changes to Corosync 2.3.5-2 
>> solves the reviously experienced issues?
>
> "Doesn't work" is #771432 which I didn't have time to properly check. 
> But also the fact that it is now disabled by default in the upstream 
> configuration.
>
> Do you use it? If there's a need for it, I'll try to take the time to 
> research it.

I don't use it myself currently, and don't ask to do research about it. 
Currently¹ the feature will be enabled or not based on the existance of 
the libcpg-dev in the development environment.  That's unstable.

Your reasoning shared here sounds sensible to me.

I suggest to a) document the reasoning as a comment in debian/rules next 
to b) explicitly disabling the feature (I guess --without-corosync would 
work but am not sure) to avoid uncertainty both in code and in following 
intend of code.


 - Jonas

¹ In my latest test builds, at least - you now mention that defaults 
have changed, but I still suggest to disable explicitly.

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20151108/bcf0274c/attachment.sig>